summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColleen Murphy <colleen.murphy@suse.de>2018-07-11 22:58:07 +0200
committerColleen Murphy <colleen.murphy@suse.de>2018-07-11 22:58:07 +0200
commit3d9839bfa4bf39cfef4e81697df35196001049e1 (patch)
tree4e61623d0acea5434dc65c19baa97a418caa2fde
parentcb806fc80bf195b4a47aa0b02c7416dca609f175 (diff)
Fix exec idempotency
The install-reviewday-dependencies exec doesn't need to be executed on every puppet run, only when the source repo is updated, so add a refreshonly => true to ensure it only reacts to changes in the source repository. Change-Id: Id3a747e49416398e3fdde9aeb843370890dbe572
Notes
Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Aug 2018 23:15:51 +0000 Reviewed-on: https://review.openstack.org/581884 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
-rw-r--r--manifests/site.pp9
1 files changed, 5 insertions, 4 deletions
diff --git a/manifests/site.pp b/manifests/site.pp
index 400a327..e898813 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -83,10 +83,11 @@ define reviewday::site(
83 } 83 }
84 84
85 exec { 'install-reviewday-dependencies': 85 exec { 'install-reviewday-dependencies':
86 command => 'pip install -r /var/lib/reviewday/reviewday/requirements.txt', 86 command => 'pip install -r /var/lib/reviewday/reviewday/requirements.txt',
87 path => '/usr/local/bin/:/bin/', 87 path => '/usr/local/bin/:/bin/',
88 subscribe => Vcsrepo['/var/lib/reviewday/reviewday'], 88 subscribe => Vcsrepo['/var/lib/reviewday/reviewday'],
89 require => Class['pip'], 89 refreshonly => true,
90 require => Class['pip'],
90 } 91 }
91 92
92 file { $httproot: 93 file { $httproot: