summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-01Merge "Don't create reviewday subdirectory"HEADmasterZuul
2018-08-01Merge "Add beaker tests"Zuul
2018-08-01Merge "Fix exec idempotency"Zuul
2018-07-19Don't create reviewday subdirectoryColleen Murphy
Perhaps because of the new resource ordering algorithm, on puppet 4 the /var/lib/reviewday/reviewday file resource blocks the /var/lib/reviewday/reviewday vcsrepo resource and results in failures like: Error: /Stage[main]/Main/Reviewday::Site[reviewday]/Vcsrepo[/var/lib/reviewday/reviewday]/ensure: change from absent to latest failed: Could not create repository (non-repository at path) On both puppet 3 and puppet 4 the vcsrepo resource will create the directory on its own, and it can also manage the directory's owner and group itself, so there is no need for it to be managed independently. Change-Id: Ic64d39a9f257d623ca13e9d38708eaa1e32e8c18 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Aug 2018 23:17:15 +0000 Reviewed-on: https://review.openstack.org/582524 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2018-07-12Add beaker testsColleen Murphy
Add basic tests to ensure the manifests can be applied cleanly and the site comes up. Change-Id: Id477b53849f6efd9715f89ca54eaa899fe08c90f Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Aug 2018 23:16:08 +0000 Reviewed-on: https://review.openstack.org/581885 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2018-07-12Update Gemfile for Zuulv3Colleen Murphy
The logic in the Gemfile was relying on Zuulv2 variables to find out whether the spec helper gem was already available on disk, and since Zuulv3 has changed things it was failing to find it and downloading the master version instead. This patch ensures the Gemfile looks for the gem in the right place when running in CI. Change-Id: Ib85eddeda99d5fc2422a8b7b994cb79e835d1f4a Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 16 Jul 2018 21:08:16 +0000 Reviewed-on: https://review.openstack.org/582061 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2018-07-11Fix exec idempotencyColleen Murphy
The install-reviewday-dependencies exec doesn't need to be executed on every puppet run, only when the source repo is updated, so add a refreshonly => true to ensure it only reacts to changes in the source repository. Change-Id: Id3a747e49416398e3fdde9aeb843370890dbe572 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Aug 2018 23:15:51 +0000 Reviewed-on: https://review.openstack.org/581884 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2017-08-18Depend on helper gem for spec_helper_acceptanceColleen Murphy
Instead of keeping a local copy of spec_helper_acceptance.rb and requiring updates to all modules for any change, we can move it into the common helper gem and require it from there. This will make it easier to create and review changes that affect all puppet modules. Also change the Gemfile to look for the gem in the local workspace if running in a zuul environment. Change-Id: I11122f08a677a581941b86b6368600e7c09fa4e2 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 23 Aug 2017 00:36:01 +0000 Reviewed-on: https://review.openstack.org/495636 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2017-06-24Fix beaker on xenialColleen Murphy
Add a xenial nodeset and update the spec helper to install puppet 3 from the Ubuntu repos instead of from puppetlabs. Change-Id: Ia336c416340d5034e3760e4d7eeb5b5be3763385 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 27 Jun 2017 20:04:52 +0000 Reviewed-on: https://review.openstack.org/477138 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-06-21Use new infra_spec_helper for gem dependenciesSpencer Krum
Change-Id: I1197843a3a081c3650260ecdd814e9b7a18a8af8 Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 22 Jun 2016 02:27:38 +0000 Reviewed-on: https://review.openstack.org/332564 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-04-21Add /usr/local/bin to path for cron jobAndreas Jaeger
gerrit-dash-creator is used by reviewday and installed in /usr/local/bin. Set the path up correctly. Change-Id: I39c8ad1ebc5971eec7ed70bd975051296738774d Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 21 Apr 2016 19:20:36 +0000 Reviewed-on: https://review.openstack.org/309100 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-04-20Create logs for update_reviewAndreas Jaeger
The cron job looks failing, put the output to a log file. Setup log file path and logrotate for it. Change-Id: Ie26e5a9f07ae122842338cf833d4462a9ce7559f Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: yolanda.robla <yolanda.robla-mota@hpe.com> Workflow+1: yolanda.robla <yolanda.robla-mota@hpe.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 21 Apr 2016 14:51:21 +0000 Reviewed-on: https://review.openstack.org/308367 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-04-14Pin google-api-client; sanitize GemfileSpencer Krum
Change-Id: Id47bc79f471c66254d0042921034e07213dc6513 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 15 Apr 2016 00:04:29 +0000 Reviewed-on: https://review.openstack.org/306153 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-04-13Merge "Order of the class parameters is refactored"Jenkins
2016-04-13Fix path for reviewday dependenciesYolanda Robla
Currently puppet is failing because it cannot find pip. That is because the exec path is set to reviewday directory. Add /usr/local/bin and /bin as valid directories in the path as well. Change-Id: I3dc47004f1ace03ffa78fabdc13158dbcc16bb28 Notes (review): Code-Review+1: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Workflow+1: Spencer Krum <nibz@spencerkrum.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 13 Apr 2016 18:11:03 +0000 Reviewed-on: https://review.openstack.org/305102 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-04-05Run pip install to install the dependenciesrossella
Id2e8590193fbf21a52a767323a77df9be4048b5a requires gerrit-dash-creator to be installed on the host where reviewday runs. This patch runs pip install to install all the dependencies. Change-Id: I42ea25bdf69a1d75db24785db0e86396206fd48d Notes (review): Code-Review+2: yolanda.robla <yolanda.robla-mota@hpe.com> Code-Review+1: Ricardo Carrillo Cruz <ricardo.carrillo.cruz@gmail.com> Code-Review+1: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Tue, 12 Apr 2016 16:54:29 +0000 Reviewed-on: https://review.openstack.org/301255 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2016-03-22Order of the class parameters is refactoredAndrey Nikitin
Order and indentation of those parameters are changed to follow Puppet Style Guide recommendation [0]. Moreover, it will allow to an user to find much faster a variable in a list of variables. [0]. https://docs.puppetlabs.com/guides/style_guide.html Change-Id: I005c80760893c1d0023104832af436ac3890e7b3 Notes (review): Code-Review+2: yolanda.robla <yolanda.robla-mota@hpe.com> Code-Review+2: Spencer Krum <nibz@spencerkrum.com> Workflow+1: Spencer Krum <nibz@spencerkrum.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 13 Apr 2016 18:13:45 +0000 Reviewed-on: https://review.openstack.org/295357 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-08-19Fix target path for regular git clone during testsSpencer Krum
Use same target directory for zuul-cloner and the regular git command. Change-Id: I60222d61f5a15236668449c719dca896fad4cce4 Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com> Notes (review): Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Workflow+1: yolanda.robla <info@ysoft.biz> Code-Review+1: Fabien Boucher <fabien.boucher@enovance.com> Submitted-by: Jenkins Submitted-at: Fri, 21 Aug 2015 08:22:43 +0000 Reviewed-on: https://review.openstack.org/214874 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-08-13Add Gemfile and puppet 4 checksColleen Murphy
In anticipation of puppet 4, start trying to deal with puppet 4 things that can be helpfully predicted by puppet lint plugins. Also fix arrow alignment errors caught by the bundle-installed puppet-lint. Change-Id: I060c65c6ca9292216620a851d402359c33ca9927 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Submitted-by: Jenkins Submitted-at: Sun, 16 Aug 2015 12:34:32 +0000 Reviewed-on: https://review.openstack.org/212872 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-08-13Set reasonable defaults for reviewday::siteColleen Murphy
Empty string is not an appropriate default value for parameters that are used unconditionally in the puppet manifest or template. For example, the name of the http root directory cannot be an empty string, so it is not sensible to use empty string as a default. This patch attempts to set reasonable defaults for every parameter. For the key parameters, we change the default from empty string to undef and update the conditional logic related to those parameters. Change-Id: I6d2e7037385a4082726e5e7db93b18a92b4a8ace Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Submitted-by: Jenkins Submitted-at: Sun, 16 Aug 2015 12:34:27 +0000 Reviewed-on: https://review.openstack.org/212871 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-08-13Fix template variablesColleen Murphy
Using ruby methods to access manifest variables is deprecated in puppet 3 and will be removed in puppet 4. This patch fixes the templates to use ruby instance variables instead. Change-Id: I7f9890379b3b79b947ddbf3e8c3fb129a0f04bb9 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Code-Review+2: yolanda.robla <info@ysoft.biz> Submitted-by: Jenkins Submitted-at: Sun, 16 Aug 2015 12:33:23 +0000 Reviewed-on: https://review.openstack.org/212870 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-07-28Boilerplate beaker-rspec filesSpencer Krum
Change-Id: I061de37e033c5eb4dd3a4e86a55aba09f3c731f3 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Jenkins Code-Review+1: Clint Adams <clint@gcfm.net> Submitted-by: Jenkins Submitted-at: Thu, 30 Jul 2015 00:31:54 +0000 Reviewed-on: https://review.openstack.org/206411 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-05-14Replace ci.o.o links with docs.o.o/infraJeremy Stanley
The http://ci.openstack.org/ documentation site has been deprecated, replaced by redirects to corresponding paths within http://docs.openstack.org/infra/ where other Project Infrastructure documentation already resides. Change-Id: Ie3cfbcd08863fbe1a51549885290ffaddf228e6a Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 14 May 2015 23:22:47 +0000 Reviewed-on: https://review.openstack.org/183286 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-04-20Rename openstackci to openstackinfraRamy Asselin
Change-Id: If6ebb81e27af25841121071a510298eb316e2b40 Notes (review): Verified+2: Jenkins Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: Jeremy Stanley <fungi@yuggoth.org> Submitted-by: Jenkins Submitted-at: Tue, 21 Apr 2015 18:15:44 +0000 Reviewed-on: https://review.openstack.org/175671 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2015-01-29Add puppet module files for puppet-reviewdayRamy Asselin
Change-Id: I168abe9e1e0e274250ebcccdb144759c8a0058d4 Notes (review): Verified+2: Jenkins Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Joshua Hesketh <joshua.hesketh@rackspace.com> Workflow+1: Joshua Hesketh <joshua.hesketh@rackspace.com> Submitted-by: Jenkins Submitted-at: Thu, 29 Jan 2015 22:39:34 +0000 Reviewed-on: https://review.openstack.org/151397 Project: openstack-infra/puppet-reviewday Branch: refs/heads/master
2013-05-14Force reviewday ssh to gerrit to use ipv4Elizabeth Krumbach
Running into issues running reviewday over ipv6 on static server, updated ssh config forcing it to use only ipv4 for ssh for now. Change-Id: I79e0b9271ff64e09bd41b1f1fbaf18eb3f90a1c4 Reviewed-on: https://review.openstack.org/29029 Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-05-10Decrease reviewday update frequency.Jeremy Stanley
* modules/reviewday/manifests/site.pp: The frequency of the update reviewday cron job is now every half hour instead of every quarter hour. Additionally, a lock is added to prevent overlapping runs in case the script begins to take longer. This is needed since recent Launchpad API changes have caused it to perform considerably slower than before. Change-Id: I9fcdbb350a61ab29200068406ccb8b8eaa5e4244 Reviewed-on: https://review.openstack.org/28331 Reviewed-by: Dan Prince <dprince@redhat.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-03-28Add gerrit url to reviewday .ssh/known_hosts fileElizabeth Krumbach
Change-Id: I01a753ecdbd0fcb22cd26ac173f1a37eff35def1 Reviewed-on: https://review.openstack.org/25567 Reviewed-by: Dan Prince <dprince@redhat.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Reviewed-by: Khai Do <zaro0508@gmail.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-03-27Keep reviewday repo up to date on filesystemElizabeth Krumbach
Changes to vcsrepo stanza in reviewday puppet module to keep the reviewday checkout up to date with changes to master. Change-Id: I0cbe2c06622545948c9b645c45eac19887b4c440 Reviewed-on: https://review.openstack.org/25555 Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-03-27Fix permissions on reviewday directoriesElizabeth Krumbach
Reviewday home and git repository directories were owned by root, fix those permissions and make http directory executable. Change-Id: I3ae856a3c1ffa13d9f8a7217284d89d8035f2613 Reviewed-on: https://review.openstack.org/25424 Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Approved: James E. Blair <corvus@inaugust.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Tested-by: Jenkins
2013-03-26Fix reviewday errors.James E. Blair
Change-Id: I702bdd6845df2cd6e9b8c464b95cca50fb783875 Reviewed-on: https://review.openstack.org/25418 Reviewed-by: Elizabeth Krumbach <lyz@princessleia.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins
2013-03-26Refactor reviewday into class and definitionElizabeth Krumbach
The reviewday puppet files have been split between static class and a definition that pulls several variables for openstack-specific use. Change-Id: Ibeb450900a75269c4c8a5aaaa51fb105aff7af15 Reviewed-on: https://review.openstack.org/24915 Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Approved: James E. Blair <corvus@inaugust.com> Reviewed-by: James E. Blair <corvus@inaugust.com> Tested-by: Jenkins
2013-03-19Add puppet files for reviewdayElizabeth Krumbach
Initial add of puppet files so reviewday can be deployed on the static webserver. Fixes: bug #1082785 Change-Id: Ie5516e82bfc9dfea95b53285c46aa881d5c05f32 Reviewed-on: https://review.openstack.org/21158 Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Jeremy Stanley <fungi@yuggoth.org> Reviewed-by: Jeremy Stanley <fungi@yuggoth.org> Tested-by: Jenkins