This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: Iae9cb7f3fdd8fb5c0bcb1112aa4eca9f3430193f
Perhaps because of the new resource ordering algorithm, on puppet 4 the
/var/lib/reviewday/reviewday file resource blocks the
/var/lib/reviewday/reviewday vcsrepo resource and results in failures
like:
Error: /Stage[main]/Main/Reviewday::Site[reviewday]/Vcsrepo[/var/lib/reviewday/reviewday]/ensure: change from absent to latest failed: Could not create repository (non-repository at path)
On both puppet 3 and puppet 4 the vcsrepo resource will create the
directory on its own, and it can also manage the directory's owner and
group itself, so there is no need for it to be managed independently.
Change-Id: Ic64d39a9f257d623ca13e9d38708eaa1e32e8c18
The install-reviewday-dependencies exec doesn't need to be executed on
every puppet run, only when the source repo is updated, so add a
refreshonly => true to ensure it only reacts to changes in the source
repository.
Change-Id: Id3a747e49416398e3fdde9aeb843370890dbe572
gerrit-dash-creator is used by reviewday and installed in
/usr/local/bin. Set the path up correctly.
Change-Id: I39c8ad1ebc5971eec7ed70bd975051296738774d
The cron job looks failing, put the output to a log file.
Setup log file path and logrotate for it.
Change-Id: Ie26e5a9f07ae122842338cf833d4462a9ce7559f
Currently puppet is failing because it cannot find pip.
That is because the exec path is set to reviewday directory.
Add /usr/local/bin and /bin as valid directories in the path
as well.
Change-Id: I3dc47004f1ace03ffa78fabdc13158dbcc16bb28
Id2e8590193fbf21a52a767323a77df9be4048b5a requires
gerrit-dash-creator to be installed on the host where
reviewday runs. This patch runs pip install to install
all the dependencies.
Change-Id: I42ea25bdf69a1d75db24785db0e86396206fd48d
Order and indentation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: I005c80760893c1d0023104832af436ac3890e7b3
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix arrow
alignment errors caught by the bundle-installed puppet-lint.
Change-Id: I060c65c6ca9292216620a851d402359c33ca9927
Empty string is not an appropriate default value for parameters that
are used unconditionally in the puppet manifest or template. For
example, the name of the http root directory cannot be an empty string,
so it is not sensible to use empty string as a default. This patch
attempts to set reasonable defaults for every parameter. For the key
parameters, we change the default from empty string to undef and update
the conditional logic related to those parameters.
Change-Id: I6d2e7037385a4082726e5e7db93b18a92b4a8ace
* modules/reviewday/manifests/site.pp: The frequency of the update
reviewday cron job is now every half hour instead of every quarter
hour. Additionally, a lock is added to prevent overlapping runs in
case the script begins to take longer. This is needed since recent
Launchpad API changes have caused it to perform considerably slower
than before.
Change-Id: I9fcdbb350a61ab29200068406ccb8b8eaa5e4244
Reviewed-on: https://review.openstack.org/28331
Reviewed-by: Dan Prince <dprince@redhat.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Change-Id: I01a753ecdbd0fcb22cd26ac173f1a37eff35def1
Reviewed-on: https://review.openstack.org/25567
Reviewed-by: Dan Prince <dprince@redhat.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Khai Do <zaro0508@gmail.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Changes to vcsrepo stanza in reviewday puppet module to keep the
reviewday checkout up to date with changes to master.
Change-Id: I0cbe2c06622545948c9b645c45eac19887b4c440
Reviewed-on: https://review.openstack.org/25555
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Reviewday home and git repository directories were owned by root,
fix those permissions and make http directory executable.
Change-Id: I3ae856a3c1ffa13d9f8a7217284d89d8035f2613
Reviewed-on: https://review.openstack.org/25424
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Change-Id: I702bdd6845df2cd6e9b8c464b95cca50fb783875
Reviewed-on: https://review.openstack.org/25418
Reviewed-by: Elizabeth Krumbach <lyz@princessleia.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
The reviewday puppet files have been split between static class and a
definition that pulls several variables for openstack-specific use.
Change-Id: Ibeb450900a75269c4c8a5aaaa51fb105aff7af15
Reviewed-on: https://review.openstack.org/24915
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Initial add of puppet files so reviewday can be deployed on the
static webserver.
Fixes: bug #1082785
Change-Id: Ie5516e82bfc9dfea95b53285c46aa881d5c05f32
Reviewed-on: https://review.openstack.org/21158
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Clark Boylan