With systemd systems it appears that ensure => running is insufficient
to make sure the service is running. You also have to enable the service
so that its unit is startable. Since we pretty much always want snmpd
running just enable it.
This behavior was noticed when git.openstack.org was rebuilt on CentOS 7
which uses systemd.
Change-Id: I44f7f73abd5ecf12dad2522a7c48df50b12f7e9b
This sort of reverts 26d074aba3172d7019a47ada003531b7b7f80584 whose
commit message included the phrase, "This can go away after
everything is upgraded to precise..."
We're well past upgrading to Ubuntu Precise, as we're actively
upgrading the last of our Precise servers to Trusty now. Further,
the initscript we backported from Precise no longer works on Xenial
which we're starting to get into production, and we haven't been
installing this file on our RH-based platforms at all, so it's long
overdue to be cleaned up.
Change-Id: I3f99495142ad1b4352c1566889381fe5c92b2936
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check gem.
Change-Id: I5ceca3010144b685a2466d7217221204c61dcc73
The osfamily fact is more flexible when we want to support more
GNU/Linux distributions while avoiding unnecessary code duplication.
Change-Id: Iea4c73c19e7f94df8daccf25c764b6a4539a1ea0
Reviewed-on: https://review.openstack.org/27400
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Clean up facter osfamily matches to just use Debian, not Ubuntu.
This is manually tested and confirmed to at least be the case on
Oneiric, Precise and Quantal.
Change-Id: I27b184ac419910f9c3271c3b4e57886333282a5f
Reviewed-on: https://review.openstack.org/27399
Reviewed-by: Spencer Krum <krum.spencer@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
The install scripts now look for CentOS in release files. Also some
instances of facter's operatingsystem are switched to osfamily and
capitalization of RedHat is normalized to match what facter uses.
Change-Id: I3bbca5481d0d5e6de9e62bfd6e2b0a85264ed6ed
Reviewed-on: https://review.openstack.org/27398
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Updates the snmpd module so that we don't require
/etc/init.d/snmpd to start the snmpd service. This
should fix issues running this module on RHEL.
On Ubuntu we explicitly create /etc/init.d/snmpd
and already has some resource chaining in place so
that it will conditionally run before the snpmd service
starts.
Change-Id: I480c38d26c8b423f5a8d1ddc405749c03aae19b1
Reviewed-on: https://review.openstack.org/23460
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
Parameterize the package name so that things work on multiple
distros.
Also, updates the snmpd module so that that the init script is
written out on Ubuntu only (this is not required on RHEL).
Change-Id: Id5868b85fc0a7a6057d9be16c76dad2efb834f0e
Reviewed-on: https://review.openstack.org/23186
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Khai Do <zaro0508@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
Change-Id: I970c492c11d91dfab3b206859a72598a16602a24
Reviewed-on: https://review.openstack.org/14906
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
Killed trailing whitespace in the puppet repo files using
`sed -r 's/\s+$//'`. Skip binary files and html templates for lodgeit
and mailman.
Change-Id: Ib43493161d8f0e8fae1426b22fb1737832ca14cd
Reviewed-on: https://review.openstack.org/12969
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
This can go away after everything is upgraded to precise,
but it's the cause of the constant puppet attempts to restart snmpd on our
servers.
Change-Id: I99b1931aefa3444d5ceef8b6dd6014152f3f53a0
Andreas Jaeger