This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: I7624791255f9b56e9ea72b18975dabb8bc755335
Puppet 4 was complaining that this variable was undefined. Define it to
make this warning go away.
We switch away from scope.lookupvar for consistency with the rest of the
var lookups in this file and to keep our conditional short.
Change-Id: I64cc9660a72bf5ab096c9c6f29080a838df5ddea
We assert a dependency on this puppi puppet module but then never use
it. Looking at the git log we used it at one time to download tarballs
but then stopped as it wasn't reliable enough.
Clean this up to make puppet 4 happier about this module not having
puppi available in production.
Change-Id: Ifed308229b92035e8b62d8b3677ca698639c6804
Change I25bd7b5d2a904dad3e13efaf2da94cce205bcc0b switched the
characterset for new databases to utf8mb4, but the Puppet MySQL
module independently defaults the collate parameter to
utf_general_ci which is not compatible with utf8mb4. Set an explicit
utf8mb4_general_ci collation instead so that the database can be
created successfully.
Change-Id: I9cc715e0b0cec9494489d56a2f4c1549782b0fca
There are two ServerAdmin entries in the https vhost erb template. One
for port 80 and one for port 443. The previous change only fixed the
issue for port 80. Fix this for port 443 too.
Additionally fix the ssl chain file variable which has the same problem.
Change-Id: Id3a36d1a3088f9ae08761f51f4073f388e2eedf8
On puppet 3 an explicit undef value is evaluated as the symbol :undef in
ERB templates, while on puppet 4 the explicit undef is evaluated the
same as the implicit undef which comes to the nil value in ERB. Check
for both values to make both puppet versions happy.
Change-Id: Ib4bff7259fea2722f799745d476d1af0c34408d5
This is required to properly support handling requests for project by
name, where the name may contain encoded slashes. For example,
GET /v1/projects/openstack-infra%2Fstoryboard
causes Apache to give a 404 error without this patch.
Change-Id: Ibe95dbfc28621574bac7e4af78fe1d913fa4e1b6
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: Ieb08b1c3d5e9400657631a97fc4ce6ea8a5763e6
Don't rely on a puppet file resource to purge the unpack dir as this
will trigger on every puppet run then copy the empty unpack dir to the
deployment dir. Instead we call rm prior to tar during the unpack exec
so that we only ever clean the dir if we are unpacking.
Change-Id: I80b4faf54220d88e610e2a224dea47af4133e225
The old webclient tarballs had content in a "dist" subdirectory, but
newer ones do not. So as to avoid webroot contamination as well as
to make sure we copy the correct new content into place, unpack the
tarballs into an empty "dist" subdirectory of the download staging
directory.
Change-Id: I15d1e00c9a0aa752b21b6eeedb29bcd89dc03935
Storyboard.o.o's webclient has been lagging behind master due to
a change in naming.
This patch fixes the tarball name so that the webclient in prod will
actually reflect whats in master.
Change-Id: I35174ab8345fa811f21947c106dd3e18dc1bce0b
Dynamic scoping for variables in ERB templates was removed in puppet
4[1] which means that the variables defined in the manifests cannot be
found when it is referenced in the httpd::vhost defined type and will be
evaluated as nil when puppet runs. Use scope.lookupvar instead to be
explicit about the variable's source.
[1] https://puppet.com/docs/puppet/4.10/lang_updating_manifests.html#dynamic-scoping-in-erb
Change-Id: I007975c920bd12a352acdea742b841a17ecc5d17
Puppet 4 is more strict about data types and doesn't tolerate using
arithmetic operators on strings. The operatingsystemrelease fact is a
string. Switch the arithmetic comparison to a native function that knows
how to deal with version numbers.
Change-Id: I98d5b4c50b26b5ea64035d726d903900c2040b99
Email notifications about task status changes triggered from Gerrit do
not include correct Story URL. Setting the default StoryBoard URL should
fix that issue.
Change-Id: Ic639e344921c4265d3471ac9bd591a4ae489ae52
Story: 2001410
Task: 6106
Use an IETF recommended domain name (example.org) in examples and
class parameter defaults instead of openstack.org. The only default
behavior change is for sender_email_address and the one site where
the default value would have been viable already has an override in
place to the same string anyway so this should result in no
effective behavior change.
Change-Id: I3e1bbb0bf4bfdd71f56cd429e890e90f2881bec5
The default "utf8" character set for MySQL only supports up to
3-byte codepoints. In order to support text with 4-byte codepoints
(at the expense of some additional storage) explicitly use "utf8mb4"
instead when creating and connecting to the database.
Change-Id: I25bd7b5d2a904dad3e13efaf2da94cce205bcc0b
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I0ccda3bc1ee78e42797fd6fcac957f2fdd0c253a
Add a xenial nodeset and update the spec helper to install puppet 3 from
the Ubuntu repos instead of from puppetlabs. Also fix linter errors.
Change-Id: I5b4650de814a23a0ef25ee8cd73ca3591b6df44e
The ssl-cert group which normally owns files under /etc/ssl is
created by a dependency of the apache module, but we need to create
files there before that service is started. Break the cycle by just
relying on the root group instead. Also update permission modes on
these files to reflect sensible systems administration practices
(read/write by root, readable by everyone except for the key file
which is inaccessible for others).
Change-Id: Ia76a344e5b4d3d7acdf0980ed7f951f8d5199052
On systems where the site FQDN is mapped to the loopback interface
in /etc/hosts, Apache doesn't apply the vhost configuration on
incoming connections to other addresses/interfaces. Apache
recommends wildcarding VirtualHost directives these days, and it's
something we already hard-code in other modules (e.g. puppet-zuul).
This _could_ conceivably cause complication for anyone trying to
coinstall this module on a server hosting other sites without
name-based hosting configured correctly, but that should be an
increasingly unusual configuration.
Change-Id: I11f5b586c4f7b42017c2eb78af4be87211343381
The snakeoil fallback defaults need to be set in the cert class,
not as defaults in the module init.
Change-Id: Id1f5dd081fa085775b96c0e374055aded203148a
Depends-On: Ifc92d78f081fc69d804c29033e96e1c94462213b
SSLv2 and SSLv3 should never be used. Update the protocol and cipher
suite lines to match the recommendations by the OpenStack Security team.
This includes opt-in to only TLS and strong ciphers.
Change-Id: I25168293cd822b2838252a71890e0c43b5a7b8f0
Our official git master is at git.openstack.org, update places
that use github instead.
Fix also broken URL.
Change-Id: Idf1501e771b88cf68797cadd4c4bc5127948728b
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: Id3974c8fad34cac7740b547c1514e2a6e534d5cc
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check and
puppet-lint-trailing_newline-check gems.
Change-Id: If9e2cd626122c4ff6338a82d87c815ae33578bac
puppet-httpd is the openstack-infra version of puppetlabs-apache
(0.0.4) release.
This patchset will remove the puppetlabs-apache namespace from -infra
allowing for possible future patchsets to use newer puppetlabs-apache
modules.
Change-Id: I4f509f1ce72b069ac89d42f2cb55550e3b5bf590
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
The http://ci.openstack.org/ documentation site has been deprecated,
replaced by redirects to corresponding paths within
http://docs.openstack.org/infra/ where other Project Infrastructure
documentation already resides.
Change-Id: I81ecea0021e349232bc36924a04869d29ad4676d
The install directories into which the storyboard api and client
are downloaded and processed are now parameterized.
Change-Id: Ic67a0730246bc7fcf38cc98e460381994ab9d736
In order to support Python3, https://review.openstack.org/#/c/152339/ is switching
to a mysql driver that's supported by Python3. This updates the puppet module to use
the new connection string.
Change-Id: Id5d9eacd8de5700675848d3129b189fad07a221b
There were two references to stdlib in the metadata.json file.
Similarly, there is a dependency on a module that cannot be directly
installed via 'puppet module install' (openstackci/httpd), so I am
switching our metadata back in line with the Modulefile until
that changes.
Change-Id: I04636b14f9cb7b945156a7f20c5321b54ffa67be
Vagrant file will provision the configuration it finds in vagrant.pp.
Node configurations for precise and trusty provided, on different IP
addresses.
Change-Id: I7b08ce4cc5acdc2ad58261f4872ba2df2e06dcf4
The content of this project is Apache 2 licensed, but we should
include a standard LICENSE file just to be clear about that.
Change-Id: Iee6320b9d7e35fbe8d3b0a9794f3e485c18ef2c8
This adds an empty, default config.json file to storyboard's webclient install.
While functionally it impacts nothing, it will remove a multitude of 404 log
errors caused by storyboard trying to load a secondary configuration.
Change-Id: Ib31e4ad1c6f03b4dd43659bd8e931d965ce7686b
Storyboard is currently failing because of requests to get the working
directory are failing. This disables that configuration option so
we have some time to investigate.
Change-Id: I8d0b8d6ce350836b8eba5822e1aa6e9920d7dc8e