Commit Graph

5 Commits

Author SHA1 Message Date
Colleen Murphy 241a60c5fa Update Gemfile for Zuulv3
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.

Change-Id: Ieb08b1c3d5e9400657631a97fc4ce6ea8a5763e6
2018-07-12 09:57:46 +02:00
Colleen Murphy 0940bd1e42 Depend on helper gem for spec_helper_acceptance
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.

Change-Id: I0ccda3bc1ee78e42797fd6fcac957f2fdd0c253a
2017-08-18 10:41:44 +02:00
Spencer Krum 5b9f6a201b Use new infra_spec_helper for gem dependencies
Change-Id: I47e6fc0f1eb7ba32fce9f1e56f7c8fd3602ab7f2
2016-06-21 18:40:22 -07:00
Spencer Krum 9fe15d9067 Pin google-api-client; sanitize Gemfile
Change-Id: I9b7fac3e4bc779fc028b421452708bf7f33e94dc
2016-04-14 15:24:24 -07:00
Colleen Murphy 88e03c0d52 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check and
puppet-lint-trailing_newline-check gems.

Change-Id: If9e2cd626122c4ff6338a82d87c815ae33578bac
2015-08-14 10:06:32 -07:00