The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I4de2d37d36adddfdf4079a4f7f90955960a444e4
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I1ce08d6d828822572223b95a77c456759850cd5a
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Fix arrow
alignment errors now caught by the bundle-installed puppet-lint.
This patch makes $users::virtual::localuser::sshkeys a required
parameter to fix the puppet-lint-empty_string-check error. If left as
empty string and the default is used, the ssh_authorized_key resource
will still create the authorized_key entry but with an empty key, which
is not useful.
Change-Id: Ica35f012f3af74159fc8b2ae5df60d11d4c15f33
Colleen Murphy