The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I5e20a7079b127ee04bb27ce16b229e0754b19480
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: Id431e76e78b6f550b1bf76eb16e9bdfd407839f4
Add a xenial nodeset and update the spec helper to install puppet 3 from
the Ubuntu repos instead of from puppetlabs.
Change-Id: I535b8b12fcb06dda485b0f491550715795195814
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.
[0]. https://docs.puppetlabs.com/guides/style_guide.html
Change-Id: Ie1fe4fca07a01f69a553c8b5b4eab7ef554942de
Use same target directory for zuul-cloner and
the regular git command.
Change-Id: I122ce6d6b1e0c9554207a5a0ca61627ff2bb5a2f
Co-Authored-By: Fabien Boucher <fabien.boucher@enovance.com>
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check and
puppet-lint-empty_string-check as well as arrow alignment errors now
caught by the bundle-installed puppet-lint gem.
The $description parameter was changed from defaulting to empty string
to defaulting to undef. The yumrepo resource behaves the same either
way.
Change-Id: If5a649068f73218a98372846ba38d2c25820c78a
puppet-httpd is the openstack-infra version of puppetlabs-apache
(0.0.4) release.
This patchset will remove the puppetlabs-apache namespace from -infra
allowing for possible future patchsets to use newer puppetlabs-apache
modules.
Change-Id: I40fede0db37ae0ed4432d6851c876cea2a7c7a82
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
The content of this project is Apache 2 licensed, but we should
include a standard LICENSE file just to be clear about that.
Change-Id: Iee6320b9d7e35fbe8d3b0a9794f3e485c18ef2c8
All of the fat comma arrows (=) in a resource’s attribute/value list
should be aligned.
Put a trailing comma after the final resource parameter.
Change-Id: If9567bf3c1978571970cac390df80f839627f45d
Closes-Bug: #1334751