Commit Graph

6 Commits

Author SHA1 Message Date
Monty Taylor 97083c52f9 Retire puppet-yum
This is no longer in use. Let's stop using it.

Depends-On: https://review.opendev.org/688563
Change-Id: I01f8fed00d0c6f7769037b0b775706b0f3cb28e4
2019-10-14 16:49:09 -04:00
Colleen Murphy 6d14b8b0ea Update Gemfile for Zuulv3
The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.

Change-Id: I5e20a7079b127ee04bb27ce16b229e0754b19480
2018-07-12 09:57:46 +02:00
Colleen Murphy cfc3500aba Depend on helper gem for spec_helper_acceptance
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.

Change-Id: Id431e76e78b6f550b1bf76eb16e9bdfd407839f4
2017-08-18 10:41:45 +02:00
Spencer Krum a598da8cfd Use new infra_spec_helper for gem dependencies
Change-Id: I0383ca0865a6488b6f8d22fdd962c7ae8c64fedc
2016-06-21 18:40:51 -07:00
Spencer Krum 1d7fd78a80 Pin google-api-client; sanitize Gemfile
Change-Id: I124cd6c1edf95d382f2444a74f52e39bf86ddc8e
2016-04-14 15:25:48 -07:00
Colleen Murphy 8d5fd86231 Add Gemfile and puppet 4 checks
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix lint
errors caught by the puppet-lint-absolute_classname-check and
puppet-lint-empty_string-check as well as arrow alignment errors now
caught by the bundle-installed puppet-lint gem.

The $description parameter was changed from defaulting to empty string
to defaulting to undef. The yumrepo resource behaves the same either
way.

Change-Id: If5a649068f73218a98372846ba38d2c25820c78a
2015-08-14 12:23:58 -07:00