The logic in the Gemfile was relying on Zuulv2 variables to find out
whether the spec helper gem was already available on disk, and since
Zuulv3 has changed things it was failing to find it and downloading the
master version instead. This patch ensures the Gemfile looks for the gem
in the right place when running in CI.
Change-Id: I6dbe35f271daa41012045c7425644571f0bbe95b
Instead of keeping a local copy of spec_helper_acceptance.rb and
requiring updates to all modules for any change, we can move it into the
common helper gem and require it from there. This will make it easier to
create and review changes that affect all puppet modules. Also change
the Gemfile to look for the gem in the local workspace if running in a
zuul environment.
Change-Id: I5c79b9661db5bec8c2de1763dc96568c9b3bba54
In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins. Also fix errors
caught by the puppet-lint-absolute_classname-check gem and arrow
alignment errors now caught by the bundle-installed puppet-lint. Avoid
trying to catch empty_string errors for now.
Change-Id: Ie881a8ac7539fbcbc283c3a572efe2e7562ac426
Colleen Murphy