Commit Graph

59 Commits

Author SHA1 Message Date
Zuul 1992485332 Merge "Add support for custom namespaces" 2017-12-09 15:46:46 +00:00
Dan Prince cca8e6ed63 Add support for custom namespaces
Defaults to 'openstack/' for backwards compat.

Change-Id: I320f6fe8d9926140660bed021624d3db1af23c7e
2017-12-09 10:11:44 -05:00
Dan Prince c1c05b6338 Fix reviewday URLs
The https://review.openstack.org/#change,123456 style links
no longer seem to work correctly. This patch updates
the URL to use the new format:

https://review.openstack.org/#/c/123456/ format which
works great.

Change-Id: If7c4fe732d3f272cbe31dabc375943559bb6afd9
2017-12-08 09:21:54 -05:00
rossella 622df39583 Use pip to install gerrit-dash-creator
Change-Id: I791233367dac6132c01586f5aa6c48903fcb5218
2016-04-19 14:47:58 +00:00
rossella c0612a2ef6 Add a link for Neutron Gerrit dashboard
In Neutron we created a tool to generate a Gerrit dashboard
that shows the most important reviews (bug fixes for high/critical bugs
and patches that implement approved blueprints) [1].
This patch adds a section to store the links of the project dashboards
in reviewday, copies the mentioned script in this repo and use it to
generate an updated link to the Gerrit dashboard.

[1] https://github.com/openstack/neutron/blob/master/tools/milestone-review-dash.py

Depends-on: I42ea25bdf69a1d75db24785db0e86396206fd48d
Change-Id: Id2e8590193fbf21a52a767323a77df9be4048b5a
2016-04-04 18:30:33 +00:00
Dan Prince 6caf710a79 Generate data_table.html
This patch updates reviewday so that it generates
both an index.html and a separate data_table.html
which can be used for importing the reviewday HTML
table into an externally styled website.

The existing reviewday OpenStack style remains the same.
This patch should prove useful for sites wishing
to re-use the "data table" format as-is inside of a
separately themed web site.

Change-Id: If9a69235484038e4b10ee8a2c66ed834f5f6a8d2
2015-09-27 21:38:37 -04:00
Dan Prince 540225b34d Ability to set the launchpad project name
Some projects use share a common Launchpad project for
reporting bugs (they don't always have split out
projects for these things). This patch updates
reviewday the --project-file format to support
specifying an altername 'launchpad_project' default.

Change-Id: I66afed988afe4c0cfa37d269fd397bcbb9e5badf
2015-09-25 15:30:47 -04:00
Dan Prince e2b4f2d0b3 Add requirements files, tox.ini updates
This patch updates the tox.ini file to create
virtualenv's using the new requirements files.

Also, adds a helper task to run reviewday in
a tox virtualenv. Useful on distros that
don't have launchpadlib packages handy...

Change-Id: I4fd2f70859d02a2402ed3b2387e1a6ffbcf588fd
2015-09-25 14:57:30 -04:00
Markus Zoeller 0517c7a499 Make the review list sortable by review type
Especially for bug review days it makes sense to sort the current
review list by review type (high prio bugfix, medium prio bugfix, ...)
This patch set introduces a new column "type" and allows a sorting for
it.

Change-Id: I3d37cccb8d6f75f6eebc2cf8ab9136ac50d4cf89
2015-08-07 16:41:36 +02:00
Eduardo Costa ae41c0124f Escape double quotes for the subject field.
Fix HTML generation when the subject field contains double quotes.

Closes-Bug: #1393023
Change-Id: Ia948d80e04ee838ad0ffd1a9cdc0ca2ef4add4c3
2014-11-15 21:15:12 -02:00
Christian Berendt 1f48536f7b Prettified all HTML files
Prettified all HTML files using Beautiful Soup with the
following script.

https://github.com/berendt/openstack-development/blob/master/prettify.py

Change-Id: I07f7a54f279d01381b91702664a80812355834d9
2014-06-08 19:21:36 +02:00
Morgan Fainberg 063b27abfc Remove WIP reviews from reviewday report
With the changeover to WIP being part of Workflow, the old WIP
detection no longer worked. This change makes WIP detection work
again and removes WIP reviews from the reviewday output.

Change-Id: Ic059b1e20708d3d6b6391fcebd7ff57afe7d7b0e
Closes-bug: 1321018
2014-05-19 14:44:33 -07:00
Dan Prince ab41e2fc7e Quit smoking.
I stopped smoking in Hong Kong... so I think it
should be safe to remove this for now. If I decide
to pick up the habit again I can always add this
back in.

Change-Id: Ibc0d533aa295ba9a26c61995d63610cc53a2b11e
2014-04-08 13:39:28 -04:00
Elizabeth Krumbach Joseph 4b7c228cbd Add JSON link and fix header
The "ReviewDay" header was far off to the right, fixing that with
edit to div and modification of CSS so it looks more like the
other pages on status.openstack.org.

Also add link to the new JSON file just below the header.

Change-Id: I45454594a20af5d20d2171899be25904a47b53ac
2014-02-24 17:39:43 -08:00
Jenkins 3e1c8d5be5 Merge "Ensure non-WIP reviews have a score of 1 as a base" 2014-02-12 20:35:29 +00:00
Jenkins aa04cf1614 Merge "Use a with block to create index.html." 2014-02-12 19:09:14 +00:00
Jenkins 20c03cd6fa Merge "Make reviewday.json world readable." 2014-02-12 18:54:34 +00:00
Dan Prince a409123c9b Use a with block to create index.html.
Also, updates our IO so we write to a .tmp file and
rename it only after the file IO is completed. This
wards off a potential race where a user could load
a page that hadn't been fully flushed to disk.

Change-Id: I04bfb7def801f11e3fcae83272879f660a8d1825
2014-02-12 11:00:04 -05:00
Dan Prince 80b63eced6 Make reviewday.json world readable.
Because we were using a python tempfile the reviewday.json
file was readable/writable only by the user that runs
bin/reviewday. Ideally this file would be world readable so
that Apache can host it properly.

In this commit we drop the use of python tempfile in
favor of just plain old open() which respects the
normal file permission settings.

This should fix a Forbidden access error I get when
trying to access http://status.openstack.org/reviews/reviewday.json
today.

Closes-bug: #1273833

Change-Id: I9e9a76e29f5c71f2496eef96a6dbf2496c42d973
2014-02-12 10:52:44 -05:00
Morgan Fainberg 3a30c64c13 Ensure non-WIP reviews have a score of 1 as a base
All non-WIP reviews should have a score of 1, this will ensure
that they are prioritized above WIP reviews. All reviews will
see an increase in score by 1 (WIP has a score of 0 now, all other
reviews start with a score of 1, and are modified up as appropriate).

Change-Id: I086cb01c7b8a71a9a1ec3cee2bd826f3d397c52e
2014-02-11 18:02:17 -08:00
Morgan Fainberg 02b04c151c Ensure WORKINPROGRESS reviews are at the bottom of the list.
WORKINPROGRESS reviews should not be at the top of the reviewday list
for a given project. The score will always be 0 for WIP reviews and
the subject line (in the generated report) will be prefixed with
a '(WIP): ' to indicate it is work-in-progress.

Change-Id: I32f7e08341dcbf1a0aa965a5f377c7fdc8613ead
2014-02-05 11:46:59 -08:00
Brant Knudson d5cc6b0bb2 Generate JSON
Generate JSON data so that tools can easily make use of the info
that reviewday generates.

A new reviewday.json file is generated that has data like

  {
    "generated": "2014-01-03 22:22:33",
    "projects": {
      "identity-api": {
        "https://review.openstack.org/#change,62961": {
          "owner": "Dolph Mathews",
          "score": 48,
          "cause": "No link",
          "feedback": {
            "lowest": 1,
            "highest": 1
          },
          "subject": "cleanup query_string documentation"
        }, ... (for each review uri)
      }, ... (for each project)
    }
  }

Change-Id: Idabafdadb3237410fa866c78d429cf46317fb3fe
2014-01-03 16:42:36 -06:00
Dan Prince 94eebe7720 Sort report by project name.
Change-Id: I90b4a17b1bd9f0eacd19c53939501ef9e00ce197
2013-10-18 10:46:46 -04:00
Dan Prince 06040bcf23 Add SS results support for ceilo/heat.
Adds Ceilometer and Heat to SmokeStack results processing.

Also, bumps the jobs count a bit to give us headroom for
more results.

Change-Id: Iabd7f03c26c9b8167fb9088cbaa83c2cae1d75f8
2013-09-09 13:10:32 -04:00
Jenkins 908856e504 Merge "Add support for latest SS result formats." 2013-09-09 16:38:11 +00:00
Dan Prince 41707f4003 Add support for latest SS result formats.
Updates our job data handling so that it works with the latest
SmokeStack job format updates. This includes:
 -new build status's for Failed, TestFail, and BuildFail
 -new job types (cloudcue)
 -display multiple jobs for each type (where appropriate)

Change-Id: I79fa21cfd489a2f524d4c98bc94b7a14b81ee831
2013-09-09 12:33:34 -04:00
Bob Ball 0dfad93f30 Added time-based score for patches
Based on the number of days since the last patch was posted

Also added a tooltip to explain scores

Change-Id: I1f13a97ddd8714297a331be91146f9742bbb9766
2013-08-29 11:08:14 -04:00
Dan Prince e2c0efd86f Update the URL's in the reviewday report for SSL
Change-Id: Iad4090aa5f15903521ca122b37772108e29c8bfa
2013-08-27 11:27:39 -04:00
Dan Prince 13bad9074e Switch smoker URL to ssl. Disable ssl validation.
Updates SmokeStack URL to be the SSL version.

Also, changes httplib2 so that we allow insecure SSL. This
is because we aren't using signed certificates with SmokeStack at the
moment.

Change-Id: I798c923efc07849be19521d7fc1730ca1e771838
2013-08-15 09:47:27 -04:00
Nachi Ueno 5a10e05f10 Rename quantum to neutron
Change-Id: Icb41c1d0237937e3b370fc9063994550f8defc50
2013-08-06 12:15:11 -07:00
Dan Prince 82c28bd48b LP specification name caching.
This updates our LP calls to obtain blueprint information so that
they run faster. Previously calling spec.name would cause an LP hit
for each spec. Given that we call lp.specification many times during
a reviewday run this was causing slow runtimes.

What we do now is just scrap the blueprint name off of the Spec URL
(thus avoiding many of the extra LP hits).

Change-Id: I4f2cbcc262973b02e3a13b9bba1edde53d5e6d9e
2013-07-17 09:55:41 -04:00
Bob Ball e95925a075 Add a 0-score for unknown score keys
Will print a warning message - so cron should email the owner of the job
when an unknown score key is encountered.

The example is blueprint db2-database which has "Not" as the priority

Change-Id: I4d43017be6a54bc3322d5aa754034a3d973d484d
Reviewed-on: https://review.openstack.org/36846
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-07-16 14:52:15 +00:00
Elizabeth Krumbach c7613421e4 Simplify combo.css
The combo.css file was very complicated and difficult to
edit, pulled out unused sections so it's easier to
maintain and compatible with our s header.

Change-Id: I23b223d3c5af7db49da9ede47f69ef9792106888
Reviewed-on: https://review.openstack.org/31141
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-05-31 14:29:11 +00:00
Elizabeth Krumbach a8b4dd6c95 Make Reviews page use common status header/footer
Switch http://status.openstack.org/reviews/ to use the common
status.o.o header and footer powered by common.js.

Change-Id: I6e742771bf9fe5b4732e0fc7abb82b8d2c623917
Reviewed-on: https://review.openstack.org/30168
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-05-23 17:27:33 +00:00
Dan Prince c3044dde38 Adds a timeout to launchpadlib connections.
The default timeout in LPlib is None which means it will just
hang. Lets set our default to 5 seconds to fix any queries
that hang.

This fixes an issue which started a week ago (when a new
version of LP was released) where reviewday would just hang
when trying to query LP for some of the bug/BP information.

Change-Id: Ia7af4efba543b25d220ccb193abbabc20b9f489f
Reviewed-on: https://review.openstack.org/28315
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-05-06 15:25:44 +00:00
Dan Prince b773205cfa Fix gerrit ssh command.
Add back a missing space which we accidentally removed in 932bfca.

This should fix issues causing zero results to display.

Change-Id: I86ae8a7217862811438dc15282415f47bf09bfb0
Reviewed-on: https://review.openstack.org/25545
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-03-27 18:36:25 +00:00
Dan Prince 01a2245f95 Remove an unsightly fork me.
Change-Id: I43efa5241ba0a93cf6272c849c6c3cc77c0b18a1
Reviewed-on: https://review.openstack.org/22995
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-02-26 18:07:02 +00:00
Elizabeth Krumbach 9bbbafddb9 Add command line option for output directory.
Add a -o, --out-dir option to specify an output directory.

Change-Id: I0c8ac1aba309f9a34b2562b18da644efd9f37f4e
Reviewed-on: https://review.openstack.org/20839
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-02-01 18:31:58 +00:00
Elizabeth Krumbach cbdc24aeef Remove warning for existing output directory.
In our configuration puppet will manage the output directory, so it
is expected behavior for it to exist, removing warning. Also
switching to distutils.dir_util copy_tree since that allows for
copying of required supporting files into an existing output
directory.

Change-Id: I38b2c6ec47fd61814554a4b5007a83553b05aeb2
Reviewed-on: https://review.openstack.org/20647
Approved: Dan Prince <dprince@redhat.com>
Reviewed-by: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-01-30 19:56:01 +00:00
Elizabeth Krumbach 932bfca9cc Add tox.ini file and fix pep8 errors.
Add tox.ini file and fix up several pep8 failures.

Change-Id: I3c64d2e790a8dfe37aa9091b001c3a5b85bc8586
Reviewed-on: https://review.openstack.org/20661
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Dan Prince <dprince@redhat.com>
Approved: Dan Prince <dprince@redhat.com>
Tested-by: Jenkins
2013-01-30 19:43:07 +00:00
Dan Prince 689e679e99 Fix html_helper to work and be pyflakes clean. 2013-01-10 10:26:01 -05:00
Dan Prince 76edce6b21 Pyflakes fixes. 2013-01-10 10:18:45 -05:00
Dan Prince e493bc9af4 pep8 fixes to html_helper.py 2013-01-10 09:23:37 -05:00
Dan Prince 22a2f51712 Look for cinder/quantum results from SmokeStack. 2012-11-14 14:13:11 -05:00
Dan Prince 2d9b56c5a1 Updated to support most recent SmokeStack job types. 2012-08-29 14:55:25 -04:00
Dan Prince 8cb7e07250 Add swift. 2012-06-15 10:53:18 -04:00
Dan Prince 80261f01e7 Sync with latest job descriptions. 2012-02-15 10:39:37 -05:00
Brian Waldon 1d772ae9b9 Report highest review if none are less than zero 2012-01-15 19:32:21 -08:00
Dan Prince 8490c34d77 Truncate revisions for job git hashes. (fixes job lookup by short git hash) 2011-12-05 09:46:33 -05:00
Brian Waldon 72f9aa535d Coloring test result links 2011-11-30 16:34:28 -05:00