opendev
/
storyboard-webclient
Code Issues Proposed changes

Fix extra padding on everything with the .row CSS class 

This extra padding is wanted in expanded tasks, but elsewhere adds
unnecessary whitespace and makes things look imbalanced. This commit
fixes edit_tasks.less to use a specific class rather than just adding
padding to the bootstrap .row class.

Change-Id: Ib06d4eb0e155abf31c002ff326aa8ab38dba4d8e
This commit is contained in:
Adam Coldrick 2016-11-03 23:25:11 +00:00
parent cf318d5367
commit 5d0b353a90
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/app/stories/template/detail.html
View File

@ -472,9 +472,8 @@
</div>
<!-- Review link should go here once implemented in the API -->
</div>
<div class="row button-row" ng-show="showDetail">
<div class="col-xs-1"></div>
<div class="col-xs-10">
<div class="padded-row" ng-show="showDetail">
<div class="col-xs-10 col-xs-offset-1">
<project-typeahead
auto-focus="false"
ng-model="task.project_id"
@ -504,7 +503,7 @@
</button>
</div>
</div>
<div class="row"ng-show="showDetail">
<div class="padded-row" ng-show="showDetail">
<div class="col-xs-10 col-xs-offset-1 task-notes"
ng-show="isLoggedIn">
<button class="btn btn-primary btn-xs pull-right"
@ -549,7 +548,7 @@
</div>
</div>
</form>
<div class="row pull-right" ng-show="!task.editing && !task.link">
<div class="padded-row pull-right" ng-show="!task.editing && !task.link">
<button class="btn btn-primary btn-xs"
ng-click="editNotes(task)">
<i class="fa fa-pencil"></i> Add notes

3
src/theme/base/edit_tasks.less
View File

@ -36,7 +36,8 @@
box-shadow: -4px 0px 10px rgba(0,0,0,0.1);
}
.row {
.padded-row {
.row;
padding-bottom : 10px;
}