This patch updated ansible-lint version on pre-commit configuration
file and updates tox.ini to install ansible and collections needed for
ansible-lint validation.
Closes-Bug: #2019875
Change-Id: Ib68f5b26ea5672d294709a8a1d7e725133be0203
It seems flake8 is no longer available in Gitlab. This change switches
the source from Gitlab to Github to avoid the following failure.
fatal: could not read Username for 'https://gitlab.com': No such device
or address
This also makes sure that functional jobs are skipped when pre commit
config is changed, to avoid the failing job graph freeze when updating
only .pre-commit-config.yaml.
Closes-Bug: #1996668
Change-Id: I79143651e432cb4a62dafdb94c839d0d782b4f9f
In [1] a release job was added for tripleo-operator. Now we need
to add the same for the tripleo-repos collection. This proposes
we move the playbook, secret and job definition to here so that
both jobs can share them. Then the jobs can be wired up into their
respective repo zuul layout files.
Once we are happy with testing (this needs to merge so we can test)
we can merge [2] and remove the duplication in t-o-a.
[1] https://review.opendev.org/c/openstack/tripleo-operator-ansible/+/803588
[2] https://review.opendev.org/c/openstack/tripleo-operator-ansible/+/810259
Change-Id: I09b24c4782db2e7cad117fb98a70a1c3d36a4301
- upgrade ansible-lint and fix reported issues
- allow us to test code using newer versions of ansible
- `yaml` callback was removed
- ini_file module is no longer shipped with code
Change-Id: I899fc736da88de337fd4ee62535755e70d61d63c
Assures consistent formatting of our python codebase without having
to rely on humans to do it, or to debate during reviews.
Change-Id: I1e62cc755fa60e453dea865f436241ecae330771
Flake8 went broken recently, adopts correct calling method to avoid
regression and fixes broken rules.
Also removes openstack-tox-pep8 from gate which was a guaranteed
failure when triggered as pep8 was removed.
Change-Id: Iba03d3051952f461bb16299a6d32475b2be43041
Bump ansible-lint to 4.1.1a6 as the previous version had a bug which
made it detect only some roles. This version finds 7 roles instead of
3. They are in good shape so no other change is needed.
Change-Id: I01f052d8203180992dedf3917616c773e4bd5c18
- reverted previours workarounds
- assures we run ansible-lint on our files
- bumped linters
- fixed new problems found by the linters
Change-Id: I7812fcfd17569b0c438f58bec73ab0f4b07e625c
- Fixes one bashate problem
- Updates linters
- Addressed most of the skip_list exclusions and removed them
Assure the `pre-commit run -a` is always run on all files instead
of old behavior which allowed linting to be broken when merging.
Bumping operation is mostly automated, we just need to run:
`pre-commit autoupdate` from time to time and fix eventual issues.
Change-Id: If75a3e49a9d570e744063ea35ea41919261ad876
Follows the same configuration that was used on
tripleo-quickstart-extras and documented use on tripleo-docs.
Change-Id: Iba8a2db92137f9f6ad28f498627eb1b87039d99f
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Ghanshyam Mann