Commit Graph

7 Commits

Author SHA1 Message Date
Marios Andreou 963ac72a0a Remove stale bash scripts from tripleo-ci repo
As discussed in the parent patch [1] we should remove these stale file as
they are no longer used. The oooq_common_functions, toci_gate_test,
toci_quickstart have all been replaced by the templated versions in [2].

The heat-deploy-times.py is replaced by the script at [3] in the
ansible-role-collect-logs repo. The generate-kill-heat.sh has not been
touched in over 2 years and as far as I can see isn't being used
somewhere (code search).

Some of these especially the common_functions/toci_ files are updated
out of confusion and causing unnecessary maintenance burden.

[1] https://review.opendev.org/c/openstack/tripleo-ci/+/782549/5#message-f29d32c0c652d0929f680030e1a4c970fb111c2d
[2] https://opendev.org/openstack/tripleo-ci/src/branch/master/roles/run-test/templates
[3] https://opendev.org/openstack/ansible-role-collect-logs/src/branch/master/roles/collect_logs/files/heat-deploy-times.py

Change-Id: If248d145cdcaa448de601b24a80a11d567fb235f
2021-04-08 12:36:53 +03:00
Sorin Sbarnea f78da2885a lint: enable black
Assures consistent formatting of our python codebase without having
to rely on humans to do it, or to debate during reviews.

Change-Id: I1e62cc755fa60e453dea865f436241ecae330771
2020-03-24 13:17:31 +00:00
Sorin Sbarnea 04e2fcf4d8 replace pep8 check with generic linters
Includes removal of file pattern from pep8 job which prevented
it from running on most changes. Linters will use multiple tools
and a pattern would make it fail to spot errors.

This check should run even if no files are changed, so it would
be able to check commit messages.

There are no real load implications because linters check is
just a simple tox execution which has minimal resource requirements.

Includes reactivaction or linting which was not running on
the entire repository. This required few minor fixes.

Partial-Bug: #1786286
Change-Id: I4d4279309af55c2663e98bd0cdec9224f03c1fa0
2018-08-29 19:03:09 +01:00
Ben Nemec 44510841d7 Handle failed resources in heat-deploy-times.py
Currently it ignores failure events and reports those resources as
still in progress.  That's not really true, so let's report how long
it took for the resource to fail.  In some cases that may be useful
information too.

Change-Id: I3eeb6a6a589574cbd556e4ce712e2454c3aec3c9
2017-06-29 15:03:00 +00:00
Ben Nemec 7487ee86be Fix deploy timestamp parsing
The event list output has appended a Z to the timestamp recently, so
we need to handle both formats now.

Change-Id: I4efe273c3f528eefbde05f6d47e7513361a95504
2016-09-13 17:51:05 +00:00
Ben Nemec 1d8af44eb8 Record Heat resource deployment times to Graphite
This way we can track how they change over time, in addition to
seeing how they behave in a single run.

Change-Id: I28618906e119ad22d10d087e2faf75337849cb74
2016-07-06 21:31:47 +00:00
Ben Nemec 9eade7cb52 Calculate deployment times for the Heat resources
Looking through our graphite metrics, by far the longest time is
spent deploying the overcloud.  This change allows us to collect
more granular data about what is using that time in the deployment.

At some point we may want to add this to the graphite data so we
can track it over time, but just making it available in the postci
logs is a good first step.

Change-Id: Ibae0f6259146dc0da73d43aba0ff31a24ae71eff
2016-05-05 21:41:12 +00:00