Commit Graph

17 Commits

Author SHA1 Message Date
Ian Wienand f76cfbab11 linters: fix spaces between filters
This fixes a number of places where we do not have spaces between
filters.  I think that this is a reasonable rule for readability (I
also think it probably was enforced, but maybe later versions got
better at detecting it?).

These are detected by a later version of Ansible lint; this change
should have no operational change to any roles but prepares us to
update in a follow-on change.

Change-Id: I07e1a109b87adce86f483d14d7e02fcecb8313d5
2022-07-27 17:13:39 +10:00
Sorin Sbarnea 0eaa5cf59a Upgrade ansible-lint to 5.0
- bumps ansible-lint to 5.0
- updates our custom rules to make them compatible with 5.0
- replace custom module mocking with native ansible-lint ones
- remove custom call of ansible-playbook --syntax-check as now this
  is done by ansible-lint
- assured molecule vars are hosted under a vars/ folder in order to
  avoid confusing linter detection.
- replaced custom rule for loop var names in role as now this this an
  optional core feature of the linter (see config)
- replaced custom rule no-same-owner with opt-in one (see config)

Change-Id: I233fae8c9036d295968a97ee80e07fde8846c633
2021-03-17 15:44:43 +00:00
Sorin Sbarnea 6b8cc6d468 More E208 (final)
Change-Id: I705d1b10696326f3d4d5bef4b5a88a83f2c3d960
2020-11-10 19:34:45 +00:00
Ian Wienand 6f43acde41 fetch-sphinx-tarball: don't run merge-output-to-logs
The merge-output-to-logs role is not doing anything in this test.  As
described inline, this merges files in
zuul.executor.work_root/<docs,artifacts> into the
zuul.executor.log_root directory so they are available in change
results.

Since this job doesn't publish anything there, this role is unused.

merge-output-to-logs currently can't run because it tries to run shell
scripts on the executor.  Thus we can remove this unused role and
restore the job.

Change-Id: I1afc905aa8d9c420bed316e99760ad7ad1d838ce
2020-10-15 14:44:03 +11:00
Albin Vass 70a8239d08 fetch-sphinx-output: do not synchronize owner
Change-Id: Ieb22cf12df974b6c29d8f0015680209afc5dfd7a
2020-05-18 17:04:39 +02:00
Tristan Cacqueray 59bacd1518 fetch-sphinx-output: introduce zuul_use_fetch_output
This change enables using fetch-sphinx-output role along with
the fetch-output role. By default the role still synchronizes
artifacts back to the executor.

Change-Id: I81c8a2faf566be694dbf1c59cbbd157dc4df5146
2020-05-12 16:38:26 +00:00
Andreas Jaeger 56b9c68ba2 Remove sphinx_output_dir
this is a partial revert of Ifd270cbc2d4bd42418b89a3b3061748ce537ae42,
we do not need sphinx_output_dir anymore, the single use that needed it
has been changed.

Change-Id: I95543b1a56c04dbfb8591612e4c48be0d8631633
2019-08-16 15:39:59 +02:00
James E. Blair bf8442a895 Return preview artifact in fetch-sphinx-output
This adds an extra variable to the role which can be used to
better control the URL which is returned as the artifact.

Change-Id: Ifd270cbc2d4bd42418b89a3b3061748ce537ae42
2019-08-14 07:58:38 -07:00
Andreas Jaeger 8493e6ad92 Fix sphinx publishing
Since change I9ed0b02d6ca20a6b679507c4d988531abc55b09d merged, we were
publishing to docs.o.o/$project/latest/html instead of
docs.o.o/$project/latest . We need to remove the final html part when
using rsync. Add an option to allow appending "/" to sphinx_output_src
so that rsync copies the content without the final html.

Change-Id: I0eed5ebf5af8d43f6a105a1fc0dcf1b0a9813dbd
2018-01-02 22:49:13 +00:00
Monty Taylor b034c85ab1
Update fetch sphinx output to use sphinx vars
The sphinx roles takes source and build parameters. Update
fetch-sphinx-output to also honor them so that a job can set them and
have both build and fetch honor them.

Change-Id: Ic9fc6648a25336b968e8727bb8f4fd4cfd1548bb
2017-11-20 18:00:31 -06:00
James E. Blair 59ad6e435a Expand docs for fetch-sphinx-output role
Change-Id: I05e36a96dd4e8d030d070423158e329d0fb84fb6
2017-09-27 15:08:49 -07:00
Paul Belanger cc59ca16ab
Allow user to select source directory in fetch-sphinx-output
It is possible doc/build/html is not the output path for sphinx. So
default to it but allow a user to override the value.

Change-Id: Ifdb258a9342216d9a2ea0162d7d00dbf0ad7fdeb
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2017-08-31 19:34:33 -04:00
Paul Belanger 5b420a9a44
Remove no_log from fetch-sphinx-output
Lets display the data in job-output.txt, it will help with debugging.
I belive we also want to filter this potentially in the webui
streaming.

Change-Id: If0d24fe135838a2f57aeaa4c3fe13b3436384d19
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2017-08-30 20:50:21 -04:00
Paul Belanger daebc230c6
Create zuul_executor_dest variable for fetch-sphinx-output
It is possible we want to upload this data into a different directory
on the executor; expose that.

Change-Id: I377f80fb245beb5165a24205ed1bb954d4f8af42
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2017-08-29 20:57:20 -04:00
Paul Belanger 9e464b6438
Enable verify_host for synchronize
There is no need to have this disabled (seems to be by default). We
already have ensured our SSH hostkeys have been setup properly.

Change-Id: I5f0ffea13b4adb053c10d56728bcf02c13255513
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2017-07-11 15:55:03 -04:00
Monty Taylor 055de47b4e
Add zuul_work_dir default to one-project roles
We'd like to be able to make some jobs that run tox on other projects
for ease of testing. This should allow us to do that.

Change-Id: I774a76eaaea16d8ea218b439a099b5c9335c2fc5
2017-07-07 17:04:46 -05:00
Monty Taylor 4b9fc09a1c
Port in tox jobs from openstack-zuul-jobs
The original idea was that we'd have a "python27" job. But it turns out
that "python27" isn't actually as universal as you might think.
"tox-py27" on the other hand is a thing that can and should always work
for people who want to run tox with the py27 env.

Port in the jobs we had in openstack-zuul-jobs.

Also, copy in the text of the old shell scripts so that we can iterate on
them and make them better piecemeal.

These are named zuul-tox not tox because we already have tox jobs
defined elsewhere. We'll need to do the naming dance while we work on
them.

Change-Id: I813f3f2ae138c07918556bc81655518023527131
2017-07-06 11:18:47 -05:00