New tox>=4 does not prefix the filenames with the env name. THis means
we'll squash together log files if more than one env is run. Address
this while on tox v3 to avoid regressions.
Change-Id: I2601cc7faa1f7a5d7f2d950d637dfa84c50717ae
This fixes a number of places where we do not have spaces between
filters. I think that this is a reasonable rule for readability (I
also think it probably was enforced, but maybe later versions got
better at detecting it?).
These are detected by a later version of Ansible lint; this change
should have no operational change to any roles but prepares us to
update in a follow-on change.
Change-Id: I07e1a109b87adce86f483d14d7e02fcecb8313d5
- bumps ansible-lint to 5.0
- updates our custom rules to make them compatible with 5.0
- replace custom module mocking with native ansible-lint ones
- remove custom call of ansible-playbook --syntax-check as now this
is done by ansible-lint
- assured molecule vars are hosted under a vars/ folder in order to
avoid confusing linter detection.
- replaced custom rule for loop var names in role as now this this an
optional core feature of the linter (see config)
- replaced custom rule no-same-owner with opt-in one (see config)
Change-Id: I233fae8c9036d295968a97ee80e07fde8846c633
Setting tox_envlist to venv by default is unintuitive for
many users. Remove this behaviour and let default tox
behaviour be the same as running tox on the commandline.
Change-Id: I1b6d59ee4ebb7f6b3adcf4bd35d7148e83389008
Otherwise this role could fail when tox is not installed in PATH.
Also updates the default behaviour to only collect the environments
configured with 'envlist' in tox.ini and collects all environments if
the envlist is set to 'ALL'.
Change-Id: I60bcc25cb853d2db3ee767a719b9ac54e421532e
This change enables using fetch-tox role along with
the fetch-output role. By default the role still synchronizes
artifacts back to the executor.
Change-Id: Iffe5ffc52ee4c765b2e23ab8b3235b6bc7c510d8
rsync --ignore-missing-args is only supported with rsync 3.1. CentOS 7
uses rsync 3.0 and fails.
We ignore missing remote files, so remove the argument and let the role
ignore an error if the files do not exist.
Update fetch-tox-output to use failed_when as well. We really want the
role not to fail (failed_when) instead of showing a failure and then the
playbook ignore it (ignore_errors).
Change-Id: I24bfb5519acccd7fd36b4839bb598436b4c8f01c
This is no longer needed since the task errors are now ignored.
Moreover this option doesn't work on el7.
Change-Id: Ic6b32999eef2fa26d63ed5d34b3b05b3ade60b32
Some tox users, such as dib-utils "tox -e functional" tests, don't
actually install a venv but just shell out to some commands.
Unfortunately, I'm not sure how to tell the difference between
intentionally missing logs like this, and what might be an
unintentional failure. ignore_missing will allow this to run.
Change-Id: Iaa85a8326e746604966a9c1bb4cc85f44e92299b
ironic-inspector redefines tox envdir, so the code to find the log files
from the environment fails. Add in an ignore to rsync so that files
being missing is not fatal.
Change-Id: Ie93af3569c13c57714e15bb6a9e852e44742662d
The previous patch is a temporary workaround to unbreak some post jobs.
Defaulting this to venv is not the right way to handle that.
Change-Id: I275ca1fcb996514f6ef0f4ac990b0daa3f0e6f68
The default in our usage is to look for venv. Let's set that correctly
here and circle back around and look for making 'all' work better.
Change-Id: If6fd028f6857a4f3e5b4564582ddc1b3bcbde96a
The current find command fails when there is an empty log directory
in the dist dir as seen here:
http://logs.openstack.org/87/508287/1/check/openstack-tox-py27/4e00cb9/job-output.txt.gz#_2017-09-29_04_10_39_589261
Update it to make it look specifically for the tox environments
specified in tox_envlist.
Make sure it supports a comma separated list as well as 'all' in
tox_envlist, as those are stated valid inputs.
Depends-On: I1c98508fe227f7f6aa1d0b2f7dcf270cecaa60d8
Change-Id: Id28dbd19f4f612e3e9b9feb6350250b18ae2f8c6
We can move the content from tox/post.yaml into an ansible role. This
allows other projects to use it.
Change-Id: Ic7fc31a372de29a3a97ef84539faf3b0a1d6e181
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Clark Boylan