Newer ansbile-lint finds "when" or "become" statements that are at the
end of blocks. Ordering these before the block seems like a very
logical thing to do, as we read from top-to-bottom so it's good to see
if the block will execute or not.
This is a no-op, and just moves the places the newer linter found.
Change-Id: If4d1dc4343ea2575c64510e1829c3fe02d6c273f
This is preparation for a later version of ansbile-lint, which finds
missing names on blocks. This seems a reasonable rule, and the
Ansible manual says [1]
Names for blocks have been available since Ansible 2.3. We recommend
using names in all tasks, within blocks or elsewhere, for better
visibility into the tasks being executed when you run the playbook.
This simply adds a name tag for blocks that are missing it. This
should have no operational change, but allows us to update the linter
in a follow-on change.
[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html
Change-Id: I92ed4616775650aced352bc9088a07e919f1a25f
This fixes a number of places where we do not have spaces between
filters. I think that this is a reasonable rule for readability (I
also think it probably was enforced, but maybe later versions got
better at detecting it?).
These are detected by a later version of Ansible lint; this change
should have no operational change to any roles but prepares us to
update in a follow-on change.
Change-Id: I07e1a109b87adce86f483d14d7e02fcecb8313d5
This change enables using fetch-translation role along with
the fetch-output role. By default the role still synchronizes
artifacts back to the executor.
Change-Id: I85c021706c1fa20f8d28b3a1f56c9435ac3836d5
Translation jobs might not produce the translation-source directory but
still succeed, e.g. if the branch is not translated.
Check for the translation-source directory and only fetch files if there
is really something to fetch.
Change-Id: I064873412bf8503c5e7d317739adb891315038f8
We publish the complete content of translation-source directory to
http://tarballs.openstack.org/translation-source . Fix
the location from where to get the files.
Change-Id: Icb17dbb3269c569ad8bc5343ec1eed10c438d91d
We need a role to fetch translation output to the executor for artifact
upload.
We also need to be able to specify a leading path when uploading
artifacts as translations go into a top dir of translation-source.
Change-Id: I014d559c330803213105ce1bf83a41a3c157df9c
Signed-off-by: Jesse Keating <omgjlk@us.ibm.com>
Ian Wienand