Commit Graph

5 Commits

Author SHA1 Message Date
Clark Boylan d49893f894 Partial address ansible-lint E208
- replaces ignore with a warn, which displays issue without affecting
  the linting outcome (allowing gradual fixing)
- bumps linter to enable the warn_list feature
- fixes a set of issues, others will be fixed in follow-up

Change-Id: I7d6f8c156b06f68f681943e88860930968e7c9f9
2020-09-29 10:29:01 +01:00
Tristan Cacqueray 2da63541b8 log-inventory: remove inventory_file usage
Change-Id: Idb785fd23e15316ae52650ed2ce62fe296cfd8b7
2018-06-27 00:48:24 +00:00
Tristan Cacqueray 050f89f067 log-inventory: set inventory_file if needed
Job running without nodeset doesn't have the inventory_file.

Depends-On: https://review.openstack.org/578235
Change-Id: I5d543b4e30746a64d9bd7706ffd52d41e3710ee6
2018-06-27 00:40:50 +00:00
Tristan Cacqueray 8ed7cf4c52 log-inventory: add missing zuul_info_dir prep
The role can't be used as-is without zuul_info_dir fact.

Change-Id: Id785f1b10e60dd09342edcebcbe7923b161add3c
2018-06-25 05:34:18 +00:00
Clark Boylan f27644c187 Split logging of inventory to its own role
The ability to read and write the inventory is privileged and requires
you are running in a trusted context. This makes testing the
validate-host role difficult as it reads the inventory file and writes
it to the job log dir.

Make a new role called log-inventory that will allow us to eventually
remove this task from validate-host enabling better testing of validate
host. Also this will allow us to log the inventory in the post-run
logging activity.

Change-Id: I4098fd140484bc54dc95b5f4c51afb1c56c7b19c
2018-04-23 15:53:15 -07:00