airship
/
armada
Code Issues Proposed changes

Remove validate_manifest_filepath 

This change removes validate_manifest_filepath and its related
test since it appears to only wrap around os.path.isfile() and
isn't used anywhere else within armada[0].

[0] https://github.com/openstack/airship-armada/search?utf8=%E2%9C%93&q=validate_manifest_filepath

Change-Id: I014045e4e4d4087780cf99ece1a2049148db8c5d
This commit is contained in:
Gage Hugo 2018-06-04 17:53:42 -05:00
parent 14157c9316
commit 65ce95f3a4
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
armada/tests/unit/utils/test_validate.py
View File

@ -218,13 +218,6 @@ data:
'airship-armada/master/examples/simple.yaml'
self.assertTrue(validate.validate_manifest_url(value))
def test_validate_manifest_filepath(self):
value = 'filepath'
self.assertFalse(validate.validate_manifest_filepath(value))
value = '{}/resources/valid_armada_document.yaml'.format(
self.basepath)
self.assertTrue(validate.validate_manifest_filepath(value))
class ValidateNegativeTestCase(BaseValidateTest):

5
armada/utils/validate.py
View File

@ -234,10 +234,5 @@ def validate_manifest_url(value):
return False
# TODO(MarshM) unused except in unit tests, is this useful?
def validate_manifest_filepath(value):
return os.path.isfile(value)
# Fill the cache.
_load_schemas()