airship
/
armada
Code Issues Proposed changes

armada Remove duplicate validation calls during an armada apply 

This PS removes dead code in pre_flight_ops() since validation
already occurs on L130.

Change-Id: Ie2f822009f1e56cdfc1273a9b308efafdb855f13
This commit is contained in:
anthony.bellino 2018-08-07 17:20:53 +00:00
parent 0a5b74440c
commit 6b58d82e07
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
armada/handlers/armada.py
View File

@ -139,13 +139,6 @@ class Armada(object):
raise validate_exceptions.InvalidManifestException(
error_messages=details)
# TODO(MarshM): this is duplicated inside validate_armada_documents()
# L126, and should be unreachable code if it has errors
result, msg_list = validate.validate_armada_manifests(self.documents)
if not result:
raise validate_exceptions.InvalidArmadaObjectException(
details=','.join([m.get('message') for m in msg_list]))
# Clone the chart sources
repos = {}
manifest_data = self.manifest.get(const.KEYWORD_ARMADA, {})