Commit Graph

127 Commits

Author SHA1 Message Date
Zuul 6869e5fa20 Merge "Installing systemd-udev with NVR" 2023-07-24 18:33:37 +00:00
Dmitriy Rabotyagov cb8418715a Installing systemd-udev with NVR
Due to the bug [1] in CentOS packaging, systemd-udev is substituted with
systemd-boot-unsigned. So you need to use NVR to properly
install systemd-udev until the bug is fixed.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2183279

Change-Id: I3c112b74b4777b9443f3c3041a51ecb770d48021
2023-07-18 10:19:21 +02:00
Dmitriy Rabotyagov 3448df38f5 Fix linters and metadata
With update of ansible-lint to version >=6.0.0 a lot of new
linters were added, that enabled by default. In order to comply
with linter rules we're applying changes to the role.

With that we also update metdata to reflect current state.

Change-Id: I8bd832c172ef87acca27f053c5223941d80f9ce1
2023-07-12 12:29:45 +02:00
Dmitriy Rabotyagov 34b6061ab5 Remove warn argument for command/shell
Since ansible-core 2.14 you can't use warn as module argument.

It's being removed to avoid module failure.

Change-Id: I7287d449b8fd0ad970e37aa63b5cb25f88197858
2023-06-30 15:28:35 +02:00
Dmitriy Rabotyagov afac01d955 Ensure systemd-udev is installed for gluster
We're relying on udev to exists for glusterfs since we're
applying overrides for it as well as attempting to restart.

While systemd-udev seems not being pre-installed in all CentOS
containers anymore.

Depends-On: https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/878926
Change-Id: Ia03ee4aeb381da00a538e3775b824f2a5ce4e01e
2023-03-29 16:28:07 +00:00
Dmitriy Rabotyagov f40c418af2 Change default mode of mount files to 644
In case of setting file permissions to 640 systemd will raise an
alert [1]. In order to avoid spamming in logs, we change default mode to
644 as no passwords or credentials are going to be stored in this file.

With that we provide a way to override file mode if needed.

[1] https://paste.openstack.org/show/b83tSrjni8iB2WNsvDfQ/

Change-Id: I73164e9d4b02d7b3fae21b912369afcd1cc64abf
2023-02-09 13:33:07 +01:00
Damian Dabrowski 480bb0c871 Fix mount's systemd unit dependency logic
Improve logic for making systemd mount dependent on
network-online.target when network filesystem is being used.

This change improves feature implemented in commit [1].

Currently when device is specified by UUID or LABEL, dependency for
network-online.target is added even it's not a network filesystem.
We should be careful with this as it may create circular dependency.
In my case, circular dependency looked like this:

network.target ->
  network-pre.target ->
    netfilter-persistent.service ->
      local-fs.target ->
        var-lib-nova.mount ->
          network-online.target ->
            network.target

Additionally, this commit was originally supposed to add dependency also
for CIFS mounts(these ones starting from '//') but it never worked in my
opinion. It was also fixed by this change.

[1] 6a9dcb6886

Change-Id: I5d2d9c074aa0390a6f8b7c8c0ba1c839fe26f6c5
2022-12-28 09:46:48 +00:00
Dmitriy Rabotyagov 526293ad5b Update tox.ini to work with 4.0
With tox release of 4.0, some parameters were deprecated and are ignored now
which causes tox failures. One of the most spread issues we have is using
`whitelist_externals` isntead of `allowlist_externals`


Change-Id: I8db7ddabfd3586136f442da4a4807fafbb91b5d3
2022-12-27 17:53:06 +01:00
OpenStack Release Bot 5e96309c7d Update master for stable/zed
Add file to the reno documentation build to show release notes for
stable/zed.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.

Sem-Ver: feature
Change-Id: Ied3df03a365480d0d07a03e17b161efe1fcd699f
2022-12-13 13:05:15 +00:00
Erik Berg fcd7137b86 Remove redundant vars line
This line was introduced by I680359ca655d0f69a40e9d29dbf1694cd0aa4ca2
for convenience, and should already be covered by the
distribution_major_version line above.

Change-Id: I8aba13ef29571730f9260dc2f6af33c168185780
2022-09-15 12:14:21 +02:00
Dmitriy Rabotyagov 076b8f940e Switch sphinx language to en
With sphinx release of 5.0.0, they changed default for language variable
to 'en' from None. With that current None valuable is not valid and should
not be used.


Change-Id: Ie1bbbbd73c3d33cb8b7bc99bf32b6497c7f40534
2022-05-30 16:01:09 +02:00
Zuul da14428068 Merge "Update documentation on role requirements" 2022-05-23 10:21:19 +00:00
Dmitriy Rabotyagov 13b2abebe7 Do not report changed for shell
Currently "Set the state of the mount" task reports changed state
every time, which makes impression that role is not idempotent.
We fix that by adding `changed_when: false` to the task.

Change-Id: I3deca051530b3c5497d70b9bc06f39483e8ef4ce
2022-05-18 19:09:28 +02:00
Dmitriy Rabotyagov 7fc88179dc Update documentation on role requirements
In README file we're refferencing plugins repo for installing
config_template from it. However, we're using module from it's
collection.
We're updating documentation along with renaming a-r-r to more common
requirements.yml and adjusting rc file
to drop not required overrides from there.

Change-Id: I7bf4c0fca678fd50be2dc041fe16efcc67c44fa5
Closes-Bug: #1961621
2022-05-13 10:54:27 +02:00
Jonathan Rosser d74c88dcb5 Add support for glusterfs mounts
Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/837706
Change-Id: I2631e6f00011942954be7c776e3c99a11bdfb28d
2022-04-20 06:53:34 +00:00
OpenStack Proposal Bot c3d4f26ed1 Updated from OpenStack Ansible Tests
Change-Id: I00a7dbd85c99af19885c129857fd232e99efeefe
2022-03-31 20:15:33 +00:00
Marc Gariepy 272ad600e2 Cleanup setup.py config
Change-Id: I5263c796a5ccaf6a420cc94c0e75954f5752150b
2022-03-31 10:34:42 -04:00
Zuul dd1b8c108c Merge "Add integrated linters test" 2022-01-25 17:24:49 +00:00
Dmitriy Rabotyagov 11187fe5ef Add integrated linters test
Change-Id: If13ccbbe0b8bd2dffcdcd6e9bb3a810e5dd9d550
2022-01-24 17:30:29 +00:00
Zuul 1380a2969d Merge "Refactor use of include_vars" 2022-01-12 15:28:45 +00:00
Jonathan Rosser 89c7ec5292 Refactor use of include_vars
Use a first_found lookup instead of a with_first_found loop so that
the 'paths' parameter can be used.

This ensures that only vars from the role are included, and not vars
from a parent calling role. This can happen when a parent role has
a higher priority vars file available for inclusion than the role
it calls.

Change-Id: Idbeb3e61d0398944af8d73db5d98352de95b91a7
2022-01-12 08:01:45 +00:00
Dmitriy Rabotyagov 43d95fb3a4 Drop plugins from role requirements
Change-Id: Ic7c353a9262c0628aafb912fa20e31fb4bad5450
2022-01-11 16:56:06 +02:00
OpenStack Proposal Bot f022abebcd Updated from OpenStack Ansible Tests
Change-Id: I4a58c7e2a0b18a7dfb9a186c1a744fb85b4cf889
2021-12-17 16:50:30 +00:00
Dmitriy Rabotyagov fd0926d201 Use config_template as a collection
Since we still use ceph-ansible that has their own implementation of
config_template module it's worth to use mentioned module as a collection
explicitly.

Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/819814



Change-Id: I69c8682c40a61e87156c1615c3b3eab67a76abe8
2021-11-30 15:17:07 +02:00
OpenStack Proposal Bot 00a542c7fc Updated from OpenStack Ansible Tests
Change-Id: If06cfb5cf7a1ef3ed21eb1244c5c86ff622af94f
2021-03-22 08:54:16 +00:00
Zuul d2aa4ab484 Merge "[reno] Stop publishing release notes" 2021-03-18 10:52:14 +00:00
Jonathan Rosser f1132fcc47 Remove references to unsupported operating systems
All references to Gentoo, SUSE, Debian stretch and Centos-7  are removed.
Conditional tasks, ternary operators and variables are simplified where possible
OS specific variables files are generalised where possible

Change-Id: I55037805e59cb6d727593f467e98568a4c030e74
2021-03-16 08:57:25 +00:00
OpenStack Proposal Bot 1ba9f5ea17 Updated from OpenStack Ansible Tests
Change-Id: Id7b97196a73c5fa1d7eefa0708eb16618ebaaf2c
2021-03-12 22:23:34 +00:00
Jonathan Rosser e5cc6f8990 Use ansible_facts[] instead of fact variables
See https://github.com/ansible/ansible/issues/73654

Change-Id: I5a83a7f237e4b7d86e8d7ee08b0e8c6b4f8a44f8
2021-02-23 09:25:49 +00:00
dmitriy 3874b9312d [reno] Stop publishing release notes
Since we copy all release notes to the integrated repo there is not need
in publishing release notes for each repository. We should only verify their
validity and linting.


Change-Id: I3a8975eb80fcbef96bf18475837d76a509560f64
2021-01-22 18:23:01 +02:00
Dmitriy Rabotyagov 483b10e5e9 Add option to use s3fs with role
Change-Id: I5cf6353a30190aa0a2f0856530a65c48437ed5ea
2021-01-05 13:52:45 +02:00
Zuul bcbd5344cf Merge "Install required packages for NFS/CephFS mounts" 2020-10-06 12:46:11 +00:00
Zuul 37f43da22d Merge "Updated from OpenStack Ansible Tests" 2020-10-06 11:16:19 +00:00
Dmitriy Rabotyagov 8e23ee78bb Install required packages for NFS/CephFS mounts
Currently it's deployer resposibility to install required binaries for
mounts to succeed, which is not really convenient. Instead of this
we can try to provide at least some basic binaries installation in case
supported type is set.

Depends-On: https://review.opendev.org/755484
Change-Id: I680359ca655d0f69a40e9d29dbf1694cd0aa4ca2
2020-10-02 18:21:09 +03:00
Zuul c703def315 Merge "Remove fail: tasks before creating mounts" 2020-10-02 13:26:38 +00:00
OpenStack Proposal Bot c95948975e Updated from OpenStack Ansible Tests
Change-Id: I6193133adf5e3175bc0359427d2d3d19cf64bca3
2020-10-02 11:56:14 +00:00
Jonathan Rosser c933848c4b Fix linter errors
Change-Id: If2ab6dfde044be031516bfae64b32bc461699760
2020-10-02 07:36:28 +01:00
Jonathan Rosser 229c94c620 Switch filesystem mount test from btrfs to ext4
BTRFS is not available on centos-8 so switch the test to ext4 instead.

Change-Id: I9bcbbe4dd2ed94f2c6db1af5f927e68f079c8a7a
2020-09-28 12:16:12 +00:00
Jonathan Rosser 081382486a Remove fail: tasks before creating mounts
We assume that the deployer knows what they are doing so remove
these tasks which add extra runtime to deployments and CI tests.

Change-Id: I4806ce34a38375461f4de1cc69c7e05cd86ff602
2020-06-17 16:05:27 +01:00
Marc Gariepy 720524c5cd remove ansible_python_interpreter
ansible_python_interpreter is now set to auto in the tests repo.
it doesn't need to be overwritten in the test anymore.

Depends-On: https://review.opendev.org/734676/
Change-Id: I310a1b3d81d726eb8c3401607a1306f44ee1a4d4
2020-06-11 15:58:53 -04:00
Zuul bc7862b001 Merge "use newer openstackdocstheme and reno versions" 2020-06-05 11:37:05 +00:00
OpenStack Proposal Bot 0c6032145e Updated from OpenStack Ansible Tests
Change-Id: If0175ee506ba555044f50610a2ddb71a3c6ecd5a
2020-06-03 19:13:15 +00:00
Andreas Jaeger bedf5758b1 use newer openstackdocstheme and reno versions
The sync from https://review.opendev.org/733244 updated to
openstackdocstheme 2.2.1 and reno 3.1.0 versions.

Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: I63feca3be7a797b2c2af8e650b938aef0f1cd782
2020-06-03 18:57:16 +02:00
OpenStack Release Bot 5188ede926 Update master for stable/ussuri
Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: If15c37aa648af362a9b301693f4c48ab78ff6225
Sem-Ver: feature
2020-06-01 13:07:26 +00:00
Zuul fa64262a5d Merge "Updated from OpenStack Ansible Tests" 2020-05-22 15:34:07 +00:00
OpenStack Proposal Bot f3393cd3d6 Updated from OpenStack Ansible Tests
Change-Id: I2c2e7cc5dde6107e143641baa884b53ba6b1bb4b
2020-05-22 07:12:26 +00:00
Andreas Jaeger f73cc34a51 Update docstheme for style
New version of openstackdocstheme (Victoria+) respects pygments_style.
Since this repo is using now Victoria (master) requirements but has
not branched for Ussuri yet, it uses the new version.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

Change-Id: I93ed87772eeea389ebf6d1cb95241091d54e9ae0
2020-05-20 17:25:19 +00:00
Zuul dda77e1e28 Merge "[ussuri][goal] Update contributor documentation" 2020-05-16 07:40:40 +00:00
Dmitriy Rabotyagov b9f6af2d22 [ussuri][goal] Update contributor documentation
This patch updates/adds the contributor documentation to follow
the guidelines of the Ussuri cycle community goal[1].

[1] https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html
Story: #2007236
Task: #38554

Change-Id: Ie362cdf314a85e33e6e9d7e79be66e3cc239e3d0
2020-05-13 00:07:02 +03:00
OpenStack Proposal Bot 5ccb118485 Updated from OpenStack Ansible Tests
Change-Id: I34e062891bb4f242694d9dc1ab432ad97333f117
2020-05-12 18:06:04 +00:00