openstack
/
ansible-role-tripleo-cookiecutter
Code Issues Proposed changes

Remove setup.py check from tox template 

Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.

Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.

More details can be found in this mailing list post:

http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html

Change-Id: I544d9940e8c89d50346c71e3df2fe1166850f7ef
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2018-10-30 10:33:18 -05:00
parent 025235fc9a
commit cb1a5fb52a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible-role-tripleo-{{cookiecutter.project_name}}/tox.ini
View File

@ -20,8 +20,6 @@ commands = bindep test
[testenv:pep8]
commands =
# Check the readme for python release
python setup.py check --strict -r
# Run hacking/flake8 check for all python files
bash -c "git ls-files | grep -v releasenotes | xargs grep --binary-files=without-match \
--files-with-match '^.!.*python$' \