Update zuul_git_dest location

Stop using /opt folder to store the location of git checkout. We don't
actually need to be root user to do that.

Change-Id: I26b13d02b73aca798deb1bbb12ce982951e59cd4
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

defaults/main.yaml

@@ -61,7 +61,7 @@ zuul_file_zuul_conf_owner: "{{ zuul_user_name }}"
 zuul_file_zuul_conf_src: etc/zuul/zuul.conf
 
 # tasks/install.yaml
-zuul_git_dest: /opt/ansible-role-zuul/git/openstack-infra/zuul
+zuul_git_dest: "{{ ansible_user_dir }}/src/git.openstack.org/openstack-infra/zuul"
 zuul_git_uri: https://git.openstack.org/openstack-infra/zuul
 zuul_git_version: master
 # zuul_git_update:

tasks/install/git.yaml

@@ -13,7 +13,6 @@
 # under the License.
 ---
 - name: Git clone zuul.
-  become: yes
   git:
     dest: "{{ zuul_git_dest }}"
     repo: "{{ zuul_git_uri }}"

tests/test.yaml

@@ -20,7 +20,6 @@
     zuul_file_zuul_scheduler_service_config_src: etc/systemd/system/override.conf.j2
     zuul_user_name: zuul-test
     zuul_user_group: zuul-test
-    zuul_git_dest: "{{ ansible_user_dir }}/src/git.openstack.org/openstack-infra/zuul"
     zuul_git_update: false
     zuul_pip_executable: pip3