In Python 3 __ne__ by default delegates to __eq__ and inverts the
result,but in Python 2 they urge you to define __ne__ when you define
__eq__ for it to work properly.There are no implied relationships
among the comparison operators. The truth of x==y does not imply that
x!=y is false.Accordingly, when defining __eq__(), one should also
define __ne__() so that the operators will behave as expected.
Change-Id: I9859ad3bdf304ba87d04c9ecabf069b0fdfe4b45
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None).
Change-Id: I72327e4c740ef11ee9cba4cda9642e4a270d1b52
When the plugin is enabled, we should always enable the service, there's
no benefit in having an extra invocation - and it can only confuse users
when they forget setting it up.
For more info see:
http://docs.openstack.org/developer/devstack/plugins.html
Change-Id: Ifcabc0955cb54f66388cac0c74b70c70ba65a1f9
This change makes Astara compatible with Newton. This change adds support
for Neutron agent reporting and service providers to work with new L3
drivers. Included in this change is a temporary filed called newton_fix.py.
This file will be removed in follow-up change after changes are migrated to
astara-neutron.
Change-Id: I5843e84e36af2e46de5b8420ca5749033c26ee69
When an exception was caught and rethrown, it should call 'raise'
without any arguments because it shows the place where an exception
occured initially instead of place where the exception re-raised.
Change-Id: Ib9d568d1d2915d5f183c076a114312c7bd9d5dfc
Some tests used incorrect order assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed).
This patch will fix the issue.
Change-Id: I44c7c6a6bf248b17c4f001586a79a91ff9d9dc3d
Partial-Bug: #1259292
The --service option to neutron-db-manage is deprecated and will be
removed soon. Use --subproject instead.
Related-Bug: #1501380
Change-Id: I4ab0f7b7c41aeed8aeb14c893f1837db94d23fd3
Add a Vagrant configuration for Astara. This makes it easy for someone
to pull the openstack/astara repository and get up and running with an
Astara setup quickly.
Change-Id: I600328c2a53a8d4aff5bf39a96aaa5b79ef99464
Signed-off-by: Kyle Mestery <mestery@mestery.com>
Instead of spawning our own threads and relying on the oslo.messaging
executor blocking, lets just use oslo.messaging's internal threading
capabilities. This converts rpc.Connection to rpc.MessagingService,
which is an oslo.service-based service and sets up messaging to managed
there instead.
Closes-bug: #1583330
Change-Id: I9f5a15f1c5dff7e90761887c519a15888096636b
Subscribe to the correct floatingip event for events that broadcast
when a nova associate or disassociate floating IP takes place.
Change-Id: I9aa0704fc7de75b22ecfb8795a65671e8ffcae23
Closes-bug: #1576886
We currently pass the ssh key read from disk straight into
cloud-init. If it contains newlines before or after, it can
break the yaml formatting of the cloud-init causing the appliance
to fail to successfull boot.
Change-Id: I26ef83dc7b02afc5e30f09447363ee27c9dca07c
Closes-bug: #1573167
In some deployments (OVS), port security must also be disabled
on the management port for communication from astara to the appliance
API.
Change-Id: I10bae7041aab7b4b143987bf07d800b3e50a6444
Closes-bug: #1573156
We currently do not allow operators to specify which endpoint type
needs to be used to reach nova and neutron via their clients. This
adds a new option that defaults to publicURL (as it is today) but
allows operators to specify internalURL or adminURL if they need.
Change-Id: I9432b4df8a5b4fc9f0cc06e6ffb662df634ec4f8
Closes-bug: #1572693