Do not install pxe_amt driver by default

AMT drivers have been removed from ironic tree. As a result,
ironic-conductor installed by bifrost with default settings
(enable_pxe_drivers=true) does not start as 'pxe_amt' driver can not be
found.

AMT drivers are now exclusively part of ironic-staging-drivers,
and setting them up (including dependencies installation) must be
handled by tasks installing those.

Change-Id: Ie85f8b7453bd99e824f63e41003db8089026d8c1

README.rst

@@ -165,9 +165,7 @@ in a stand-alone fashion.
   chain-loading to iPXE, which then fetches the ironic-python-agent ramdisk
   from Nginx.
 * Deployments are performed by the Ironic Python Agent, which as configured
-  supports IPMI, iLO, and UCS drivers.  AMT driver support is also enabled,
-  however it should only be used for testing as due to a known bug which
-  can be read about at https://bugs.launchpad.net/ironic/+bug/1454492.
+  supports IPMI, iLO, and UCS drivers.
 * By default, installation will build an Ubuntu-based image for deployment
   to nodes.  This image can be easily customized if so desired.
 
@@ -512,7 +510,6 @@ Default Mode
 When not in testing mode, bifrost enables the following ironic drivers:
 
 * agent_ipmitool
-* pxe_amt
 * agent_ilo
 * agent_ucs
 

playbooks/roles/bifrost-ironic-install/README.md

@@ -86,7 +86,7 @@ extra_kernel_options: Default undefined.
 
 When testing, the default ironic conductor driver is "agent_ssh". When
 testing mode has not been engaged, drivers can be set via the enabled_drivers
-variable which defaults to: "agent_ipmitool,pxe_amt,agent_ilo,agent_ucs"
+variable which defaults to: "agent_ipmitool,agent_ilo,agent_ucs"
 
 By default, PXE driver baseline support, in terms of installation of the
 iSCSI client and configuration of sudoers and rootwrap configuration is

playbooks/roles/bifrost-ironic-install/defaults/main.yml

@@ -152,7 +152,7 @@ download_ipxe: false
 enable_pxe_drivers: true
 # Comma-separated list of PXE drivers to enable when
 # enable_pxe_drivers is set to true
-pxe_drivers: "pxe_amt,pxe_ssh,pxe_ipmitool,pxe_ilo"
+pxe_drivers: "pxe_ssh,pxe_ipmitool,pxe_ilo"
 
 # Settings related to installing bifrost in a virtual environment
 enable_venv: false

playbooks/roles/bifrost-ironic-install/defaults/required_defaults_Debian_family.yml

@@ -36,7 +36,6 @@ required_packages:
   - kpartx
   - qemu-utils
   - python-openwsman
-  - amtterm
   - sgabios
   - libvirt-bin
   - debootstrap

playbooks/roles/bifrost-ironic-install/defaults/required_defaults_Debian_jessie.yml

@@ -34,7 +34,6 @@ required_packages:
   - genisoimage
   - kpartx
   - qemu-utils
-  - amtterm
   - sgabios
   - libvirt-bin
   - debootstrap

playbooks/roles/bifrost-ironic-install/defaults/required_defaults_RedHat_family.yml

@@ -40,7 +40,6 @@ required_packages:
   - sgabios-bin
   - libselinux-python
   - policycoreutils-python
-# NOTE(cinerama): amtterm is not currently packaged for RHEL/CentOS 7.
   - libvirt-daemon
   - debootstrap
   - gcc

playbooks/roles/bifrost-ironic-install/defaults/required_defaults_Suse_family.yml

@@ -43,7 +43,6 @@ required_packages:
   - openwsman-python
   - qemu-sgabios
   - policycoreutils-python
-# NOTE(cinerama): amtterm is not currently packaged for SuSE.
   - libvirt-daemon
   - debootstrap
   - iptables

playbooks/roles/bifrost-ironic-install/defaults/required_defaults_Ubuntu_16.04.yml

@@ -27,7 +27,6 @@ required_packages:
   - kpartx
   - qemu-utils
   - python-openwsman
-  - amtterm
   - sgabios
   - libvirt-bin
   - debootstrap

releasenotes/notes/drop-amt-e4bfb6e2ae3c4301.yaml

@@ -0,0 +1,6 @@
+---
+upgrade:
+  - |
+    bifrost no longer supports installing ironic AMT drivers when PXE drivers
+    are enabled (which is the default) due to AMT drivers have been removed
+    from ironic in Ocata release.