playbooks: roles: Do not force dependency upgrades

pip >= 10 is very strict when it comes to satisfying dependency
requirements. If python-foo is installed from the distro repos but
a higher version is available in pypi, then pip will try to upgrade the
package and fail with the following error:

 It is a distutils installed project and thus we cannot accurately determine
 which files belong to it which would lead to only a partial uninstall.

As such, lets make pip less aggressive by allowing existing packages to
satisfy dependency requirements.

Change-Id: I3a28abd4a68676fda180694a030ea40c7552d8d2

playbooks/roles/bifrost-ironic-install/tasks/inspector_install.yml

@@ -19,7 +19,7 @@
     state=latest
     sourcedir={{ ironicinspector_git_folder }}
     source_install={{ ironicinspector_source_install }}
-    extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ upper_constraints_file }}"
+    extra_args="--no-cache-dir --upgrade --upgrade-strategy only-if-needed -c {{ upper_constraints_file }}"
 
 - name: "Inspector - PIP client install"
   include: pip_install.yml
@@ -27,4 +27,4 @@
     state=latest
     source_dir={{ ironicinspectorclient_git_folder }}
     sourc_install={{ ironicinspectorclient_source_install }}
-    extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ upper_constraints_file }}"
+    extra_args="--no-cache-dir --upgrade --upgrade-strategy only-if-needed -c {{ upper_constraints_file }}"

playbooks/roles/bifrost-ironic-install/tasks/staging_install.yml

@@ -19,4 +19,4 @@
     state=latest
     sourcedir={{ staging_drivers_git_folder }}
     source_install={{ staging_drivers_source_install }}
-    extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ upper_constraints_file }}"
+    extra_args="--no-cache-dir --upgrade --upgrade-strategy only-if-needed -c {{ upper_constraints_file }}"

playbooks/roles/bifrost-keystone-install/tasks/install.yml

@@ -64,7 +64,7 @@
     state=latest
     sourcedir={{ keystone_git_folder }}
     source_install={{ keystone_source_install | bool }}
-    extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ upper_constraints_file }}"
+    extra_args="--no-cache-dir --upgrade --upgrade-strategy only-if-needed -c {{ upper_constraints_file }}"
   when:
     - skip_install is not defined
     - enable_venv | bool == true
@@ -99,7 +99,7 @@
     state=latest
     sourcedir={{ keystone_git_folder }}
     source_install={{ keystone_source_install | bool }}
-    extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ upper_constraints_file }}"
+    extra_args="--no-cache-dir --upgrade --upgrade-strategy only-if-needed -c {{ upper_constraints_file }}"
   when:
     - skip_install is not defined
     - enable_venv | bool == false