Commit Graph

30 Commits

Author SHA1 Message Date
Sharpz7 4529d48afe [codespell] Fixing Spelling Mistakes
This is the first in a series of commits to add support for codespell. This is continuning the process completed in ironic-python-agent.

Future Commits will add a Tox Target, CI support and potentially a git-blame-ignore-revs file if their are lots of spelling mistakes that could clutter git blame.

Change-Id: I41b2db35cdf21917ac20ed0866af3b9c94789f0b
2024-01-25 21:31:33 +00:00
Matt Crees a6ce283146 Replace Cirros references with generic descriptors
Often it is beneficial to use the functionality provided by `use_cirros`
and `cirros_deploy_image_upstream_url` to download and test with images
of other OS distributions. This patch changes the variable names to
reflect that use case.

`use_cirros` -> `download_custom_deploy_image`
`cirros_deploy_image_upstream_url` -> `custom_deploy_image_upstream_url`

The functionality of the old variables is retained for backwards
compatability.

Co-Authored-By: Alex Welsh <alex@stackhpc.com>

Change-Id: I8b3a973bd5ef19333af563c170b2a28fbbfb5c76
2023-08-10 11:41:32 +01:00
Maksim Malchuk 45a92ea49c Fix ansible-lint
Change-Id: I3c8658d0cd3e0ec9c2b82f9ca5dfe7415af79cde
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-24 09:16:40 +12:00
Riccardo Pittau 01d242bcdd Fix deprecated module ansible lint error
Also reduce verbosity of ansible-lint as we don't really need
so much DEBUG output, errors may get lost in there.

Change-Id: I5f5a3ffd7f69275685695992732ed98549c6e5fa
2023-01-09 09:58:09 +01:00
Dmitry Tantsur 4cb0395d75 Make virtual environment owned by root
It's dangerous to allow a regular user to write into the source code of
the services. The repositories are still writable, so that the
development workflow can still use the ``--develop`` flag to make
modifications.

While here, remove the horribly outdated and broken ANSIBLE_INSTALL_ROOT.

Change-Id: Id2e25dd57668d24a11dc2cd16eea2b607b7a3f16
2022-01-25 15:59:42 +01:00
Dmitry Tantsur fd530ac5aa Support Ansible 2.10
No code changes required, but the linters job needed fixing since now
it tries to automagically load the collections in playbooks/collections
and fails with "relative resource paths not supported".

Change-Id: Ifa99a4bccc52f095c057a082fbe3d15a1633de9f
2020-11-03 11:31:14 +01:00
Dmitry Tantsur ef51bdc4ad Let us finish the rabbit hunt
This change removes support for RabbitMQ. It's no longer needed by any
services, we've agreed to find an alternative for multi-node inspector,
and neutron will likely stop needing it with the switch to OVN (and
that is assuming we ever get to supporting neutron, which is unlikely).

Change-Id: I2dbefe3482addfb9cd65c34d8d1007a501531399
2020-08-31 13:50:24 +02:00
Dmitry Tantsur 2cf21258af Remove support for non-venv deployments
It has been deprecated and untested since ussuri, time to move on.

Change-Id: Ieddda38b12d07a2a5c51650850b150dd82f332a9
2020-08-25 11:08:09 +02:00
Dmitry Tantsur 6f825b0241 Add a CI job with ansible-lint
The implementation is copy-pasted with some tweaks from project-config
CI jobs. A list of exclusions is currently huge and should be reduced.

Change-Id: I7811884caa5d6c46e42bc4d1638ccaa4d17910b7
2020-08-24 13:15:34 +02:00
Riccardo Pittau 3b1fd3c01d Vagrant: run ansible-playbook from venv
The VENV env variable is defined but not used, if we don't specify
the correct path for the ansible-playbook binary, the task will
fail.

Change-Id: I425445fc3c716d085ba9c93fa253b649ee7c0438
2020-01-21 11:18:37 +00:00
Julia Kreger 44196ea91b Switch to use a venv by default for testing
Also updates the method to use the python3 native
venv module instead of the virtualenv module.

Change-Id: Iae4248acec0b3bdf48be62134f64356d40375dde
2020-01-15 17:18:54 +00:00
Julia Kreger a2b9412c0a Skip status code check and make vagrant install quicker
Under some failure conditions, the status code is not returned.

Also skip the agent/os build steps for install inside of vagrant
which can add a substantial amount of time to the build process.

And minor revision to the test-bifrost.yaml conditional as the
pattern was traditionally "is defined", but when running the test
scripts, most things are defined, so it was just a side effect of
changes being purely tested in CI over time.

Change-Id: Icf132b71b243f9fce9d1c2afca656299befcfabc
2020-01-08 19:31:01 +00:00
Julia Kreger eadaec1c33 Explicitly set python interpreter for vagrant exec
Things get a little confusing for ansible and we changed the
main scripting to somewhat expect this when explicitly
executing the install playbook, as is in test-bifrost.sh.

Change-Id: I2bfea0e383387bf3c78359ffa8b98e4965ad3709
2020-01-08 19:30:33 +00:00
Julia Kreger 0ab46209e7 Fix/update Vagrant image
Updated vagrant steps to install vagrant with a generic image
and the libvirt provider and Ubuntu Bionic.

Also attempts to update the configuration such that systemd does
not try to continually re-assert the eth0 network IP address which
allows vagrant users to reach the same failure points in setup as
OpenStack CI.

Change-Id: Id8705dc80137ec27870017b400fd3a6ee5007ebf
2020-01-06 12:31:42 -08:00
Jenkins a8e2352a48 Merge "Centralize user documentation" 2017-08-11 11:02:57 +00:00
Julia Kreger aad9617163 Centralize user documentation
Change-Id: Icf1643f3d6c87a596e6a6b5cdb73dced42ea0797
2017-08-11 09:09:22 +00:00
Julia Kreger 631717d92a Removing ssh driver references
The ssh drivers are gone, long live the ssh drivers~

Removing from the optional drivers list entry for pxe
drivers, removed from tests, examples, role documentation
and the helper script that is not used for testing, since
it is completely outdated at this point since we've been
using the role for quite a long time.

Change-Id: Ibafc4db4b326aafef80660be35ecd1dbad57cb51
2017-08-11 09:05:46 +00:00
Cédric Ollivier 11e514c543 Fix tools/vagrant_dev_env/vagrant.yml
It sets the correct working dir when calling scripts/env-setup.sh.
It also stops sourcing /opt/stack/ansible/hacking/env-setup as it is
no longer needed.

It currently conforms with README.rst.

Change-Id: If921b6b0df98d9e4e725b79168fbb3f500939362
Signed-off-by: Cédric Ollivier <ollivier.cedric@gmail.com>
2017-07-25 11:07:30 +02:00
Yolanda Robla Mota a3f09bf30c Add instructions to setup ip on provisiong on virsh
This is useful when interface comes without any ip configured,
so it is down and cannot be used.

Change-Id: Ic930245ff5a8dbcc50d46858fc0c1f3d8a98fa7d
2016-11-08 17:09:26 +01:00
Yolanda Robla Mota af24107ac3 Add instructions to deploy bifrost on virsh
Change-Id: I0005acde1b193f2ee6593dcf97a6f3b0a0760547
2016-10-17 17:00:02 +02:00
Julia Kreger 1d19d285f1 Change Vagrant VM to mirror memory/cpu in CI
Due to the differing performance profile of gate machines,
and that the settings often need to be chnaged in order
to mirror gate testing, it may be good to change the VM
defaults.

Change-Id: I6fc42cb279c0e930804c4f07cc820858f606cc6c
2016-08-15 20:38:38 +00:00
Ganesh Maharaj Mahalingam e7fc06aadc Make ansible installation directory configurable
This change helps with the remote problem where ansible is installed
on a machine using the same script by User A and User B is also
trying to use ansible using the same method. The change lets each
user have his own copy of ansible installed in a directory of
his/her choosing.

Change-Id: I8fddaaa8cad291da840ac44c4b1e9a7a93f92aee
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Partial-Bug: #1589672
2016-06-06 13:24:46 -07:00
Devananda van der Veen 040ccabeeb add scripts/README and tools/README
Add two README files to avoid any confusion about the intent of the
scripts/ and tools/ directories.

Change-Id: I50d94088649ec6b6d7f0799f40760e03b5aad371
2016-03-16 18:42:29 +00:00
Himanshu Garg 0d00c0fdf8 Fix Download get-pip play in vagrant.yml
Fixes syntax for get_url module in ansible playbook vagrant.yml
which was causing the vagrant up command to fail.

Change-Id: Iffb0b17c8f808b33538b06d21c52ca603f018a9c
Closes-Bug: 1521750
2015-12-01 19:15:03 -06:00
stephane 1920428599 Migrate playbooks to use 'become'
Ansible is scheduled to remove the 'sudo' module
and replace it with 'become'. Switch to using this
now since it is already supported in 1.9.

Closes-Bug: #1504535

Change-Id: Ie63816e36a95c86d54fea5f50325522b41597047
2015-10-15 07:32:05 -07:00
Monty Taylor c4636fe436 Stop using distro setuptools and easy_install
distro setuptools is old and should never be touched if you're going
to install things from pip. easy_install is insecure and open to
MITM attacks.

Downloading get-pip.py over https and running it will install modern
pip and setuptools on the system and is the preferred method for
installing pip in all cases.

Change-Id: I1bf88f018806142ca639f3c183598b318636e61d
2015-10-04 13:07:47 -04:00
Devananda van der Veen 7b315c8b0f Vagrantfile and vagrant.yml for testing
Also adds a readme file for vagrant.

Change-Id: I46e60bdda83db8733019cdbcd8c2c326f3f1e1a8
2015-07-23 11:09:03 -07:00
Julia Kreger 9e88296cd1 Correct legacy VM creation script to specify driver
Added columns 13 thru 16  which defines the ipmi_target*, ipmi_transit*
and ironic driver fields which in this case default to empty and agent_ssh for
the driver.

Change-Id: I32feb85ae5dc2343aa1b0a3cca92ee4697fd2c05
2015-07-02 11:52:27 -07:00
stephane 4c936f6fab Add ability to write CSV file
Let users write the CSV content out to a file rather than redirecting,
copy/paste, etc. etc.

Change-Id: Icdae8bfd197c015fb803558668b77c9c7a420611
2015-05-26 16:47:09 -07:00
Julia Kreger fa584a9917 Changing testing to utilize role
Changed the test-bifrost.yml playbook to utilize the basic vm
creation role, and moved the vm creation script to the tools
folder.
2015-03-27 20:44:10 -04:00