This is to ensure that the charm doesn't trample on the system packages
for the things that it needs to install, and that it will cooperate with
another reactive charm, especially as it is a subordinate.
Also fix some PEP8 E722 errors as that seems to have been added to the
pep8 standard set.
Change-Id: I9efb78c6f738db2284677dbde85f9e2a3ed0a6fe
Every reactive charm that uses charms.openstack and implements unit
testing needs to mock charmhelpers, as otherwise the tests blow up.
This patch uses the mocking of charmhelpers in charms.openstack so that
a charm layer can just import test_mocks and charmhelpers will be mocked
out along with setting up a default
charmhelpers.c.o.u.OPENSTACK_RELEASES so that when an OpenStackCharm()
derived charm class won't fail on definition.
Change-Id: I84eccd82f095c5c379c6d9850d266f38f589a4a4
Related-Bug: #1693017
Depends-On: I5ac40617ee30e5f421ec16fc7592177a5e6aa166
This was a combination of the smoke test being incorrectly specified
and there being no assess_status() at the end of the hsm_connected()
function. Also the assess_status() was removed from the layer-openstack
which meant that the status wasn't updating.
The change adds in an assess_status() call, but also reworks the tests
so that they use the new features in charms.openstack, and also uses
defaults for config-changed and assess-status hooks/events.
The gate that tox.ini is the keystone-v2 version of the tests.
Change-Id: Ib8082a083b05eba872d8a2e5fe477352df25ccbb
Closes-Bug: #1629624
Update tox.ini to lint unit_tests, clean lint.
Add src/README.md placeholder to prevent inheritence of the
lower layer readme file in the built charm.
Add src/tox.ini and test-requirements for Amulet prep.
Update metadata.yaml for series.
Update tox.ini to minimize and clarify pep8 ignores.
Resolve flake8/pbr test-requirements version range conflict.
Mock apt in unit tests.
Add required tags data in src/metadata.yaml for charm proof.
Use openstack/charms.openstack proper in test-requirements
instead of a user space fork.
Update src/layer.yaml repo value to point to official location
and remove unnecessary options.
Change-Id: I5ca9e6cf9f8f91b3ce0ec3b48cf63535ca37c0f7
Working charm with unit tests. Various features:
Change the install ownership for token store
It turns out that the 'user' that creates the token store, is the only one that
can access it, apart from root. As Barbican uses a 'barbican' user for the
barbican-worker process, we need to create the token store with 1777 perms (see
https://github.com/opendnssec/SoftHSMv2/issues/185) and also create the initial
token using the barbican user.
Add an initial README.md: This describes the charm, where to get help
and how to use it.
Hervé Beraud