The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.
Note that https://github.com/openstack/charms.openstack is used during tests
and he need `mock`, unfortunatelly it doesn't declare `mock` in its
requirements so it retrieve mock from other charm project (cross dependency).
So we depend on charms.openstack first and when
Ib1ed5b598a52375e29e247db9ab4786df5b6d142 will be merged then CI
will pass without errors.
Depends-On: Ib1ed5b598a52375e29e247db9ab4786df5b6d142
Change-Id: Ie62d7878f7b952f35ca854cc36ee55b62af5f8c1
Remove upper bound on flake8 and tidy misc lint on codebase.
Note that one of the warning messages signalled that a parameter
was not used in a format call. This may or may not be correct
but this commit sticks with the existing behaviour.
Change-Id: Ifa178694a97997f992afa88f4a8f3bead09ced3b
Every reactive charm that uses charms.openstack and implements unit
testing needs to mock charmhelpers, as otherwise the tests blow up.
This patch uses the mocking of charmhelpers in charms.openstack so that
a charm layer can just import test_mocks and charmhelpers will be mocked
out along with setting up a default
charmhelpers.c.o.u.OPENSTACK_RELEASES so that when an OpenStackCharm()
derived charm class won't fail on definition.
Change-Id: Ia9744ea95f0766769daa8e8c31d422ee79c3afc5
Related-Bug: #1693017
Depends-On: I5ac40617ee30e5f421ec16fc7592177a5e6aa166
Add src/README.md placeholder to prevent inheritence of the
base layer's readme file in the built charm.
Use the official charms.openstack repo in test-requirements.txt.
Use official designate charm location in the Amulet tests.
Remove upload-and-publish so as not to encourage out-of-band
pushing and publishing. That is handled by CI.
Remove legacy Makefile.
Rename Amulet test files and drop Icehouse on the Trusty target.
Update tox.ini for Amulet environment variables.
Update metadata.yaml, removing EOL release and adding tags.
Fix apt_pkg mock
Disable py27 unit tests
Change-Id: I5220b73eb41e42cb03e6dac27525140fb21ca449
Hervé Beraud