openstack
/
charm-interface-hacluster
Code Issues Proposed changes

py3: sort CRM group members 

Ensure that CRM group members are sorted to avoid continual
data mutation on ha relations to the hacluster charm, which
causes restarts of services and vips.

Change-Id: I80ca19fa5f1d573827ea9cd7fe0f18c575518c8c
Closes-Bug: 1754149
This commit is contained in:
James Page 2018-03-22 11:14:30 +00:00
parent 495e8b1f33
commit 8c72945ead
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
requires.py
View File

@ -144,7 +144,8 @@ class HAClusterRequires(RelationBase):
for vip_res in vip_resources:
if 'vip' in vip_res:
vip_res_group_members.append(vip_res)
resources.group(group, *vip_res_group_members)
resources.group(group,
*sorted(vip_res_group_members))
self.set_local(resources=resources)
@ -190,7 +191,8 @@ class HAClusterRequires(RelationBase):
for dns_res in dns_resources:
if 'hostname' in dns_res:
dns_res_group_members.append(dns_res)
resources.group(group, *dns_res_group_members)
resources.group(group,
*sorted(dns_res_group_members))
self.set_local(resources=resources)