openstack
/
charm-keystone
Code Issues Proposed changes

Remove cluster-change-departed hook 

The cluster-change-departed hook is tied to the cluster-changed
hook. In the cluster changed hook, there is logic to ensure the
initial admin exists which makes calls to the keystone service.
If the remote database has already been removed (as seen in recent
CI runs), then this will cause the hook to fail execution.

This is safe to remove as the primary purpose of the cluster-changed
hook is to sync the SSL keys and update identity relation units.
There should be no need to sync the keys when a unit is departing
the cluster relation. Likewise, the update of the identity relations
are not needed either as the VIP is used for access to the keystone
services by remote units and the access credentials won't change.

Change-Id: Id8fed284557f67f5676189ec8951b778cf506c97
Closes-Bug: #1713108
This commit is contained in:
Billy Olsen 2017-08-25 11:10:14 -07:00
parent 3343505374
commit 97861e9c46
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hooks/keystone_hooks.py
View File

@ -580,8 +580,7 @@ def cluster_joined(rid=None, ssl_sync_request=True):
send_ssl_sync_request()
@hooks.hook('cluster-relation-changed',
'cluster-relation-departed')
@hooks.hook('cluster-relation-changed')
@restart_on_change(restart_map(), stopstart=True)
@update_certs_if_available
def cluster_changed():