openstack
/
charm-nova-cloud-controller
Code Issues Proposed changes

Drop nova-cert >= newton 

nova-cert was deprecated @ newton, and only supports ec2 services
which we dropped in the charms @ liberty so remove installation
and configuration of this service for >= newton.

Change-Id: I6d0ed6a1e058f38cb5d556a34b6f4299bf6d2055
This commit is contained in:
James Page 2017-06-21 11:59:45 +01:00
parent 5d3c601dd4
commit e8f5341034
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hooks/nova_cc_utils.py
View File

@ -198,7 +198,8 @@ BASE_SERVICES = [
AWS_COMPAT_SERVICES = ['nova-api-ec2', 'nova-objectstore']
SERVICE_BLACKLIST = {
'liberty': AWS_COMPAT_SERVICES
'liberty': AWS_COMPAT_SERVICES,
'newton': ['nova-cert'],
}
API_PORTS = {

27
tests/basic_deployment.py
View File

@ -70,8 +70,13 @@ class NovaCCBasicDeployment(OpenStackAmuletDeployment):
self._initialize_tests()
def _assert_services(self, should_run):
services = ("nova-api-os-compute", "nova-cert", "nova-conductor",
"nova-scheduler", "apache2", "haproxy")
services = ["nova-api-os-compute", "nova-cert", "nova-conductor",
"nova-scheduler", "apache2", "haproxy"]
cmp_os_release = CompareOpenStackReleases(
self._get_openstack_release_string()
)
if cmp_os_release >= 'newton':
services.remove('nova-cert')
u.get_unit_process_ids(
{self.nova_cc_sentry: services},
expect_success=should_run)
@ -277,11 +282,16 @@ class NovaCCBasicDeployment(OpenStackAmuletDeployment):
self.keystone_sentry: ['keystone'],
self.glance_sentry: ['glance-registry', 'glance-api']
}
_os_release = self._get_openstack_release_string()
if CompareOpenStackReleases(_os_release) >= 'liberty':
cmp_os_release = CompareOpenStackReleases(
self._get_openstack_release_string()
)
if cmp_os_release >= 'liberty':
services[self.nova_cc_sentry].remove('nova-api-ec2')
services[self.nova_cc_sentry].remove('nova-objectstore')
if cmp_os_release >= 'newton':
services[self.nova_cc_sentry].remove('nova-cert')
if self._get_openstack_release() >= self.trusty_liberty:
services[self.keystone_sentry] = ['apache2']
@ -853,11 +863,16 @@ class NovaCCBasicDeployment(OpenStackAmuletDeployment):
'nova-conductor': conf_file
}
_os_release = self._get_openstack_release_string()
if CompareOpenStackReleases(_os_release) >= 'liberty':
cmp_os_release = CompareOpenStackReleases(
self._get_openstack_release_string()
)
if cmp_os_release >= 'liberty':
del services['nova-api-ec2']
del services['nova-objectstore']
if cmp_os_release >= 'newton':
del services['nova-cert']
if self._get_openstack_release() >= self.xenial_ocata:
# nova-placement-api is run under apache2 with mod_wsgi
services['apache2'] = conf_file