openstack
/
cinder
Code Issues Proposed changes

Fix policy in code docs for extended_snapshot_attributes 

This is to fix policy in code docs for the policy
'volume_extension:extended_snapshot_attributes' which currently
incorrectly says that the policy is enforced for GET /snapshots
which is wrong [0].

According to the code, the policy is enforced for show and details
(GET /snapshots/{snapshot_id} and GET /snapshots/details) [1].

This was also confirmed using Patrole test [2].

[0] 831665f59a/cinder/policies/snapshots.py (L48)
[1] 831665f59a/cinder/api/contrib/extended_snapshot_attributes.py (L30)
[2] I7770148584e10a08b3e133b1793a1533f1728fc1

Change-Id: I7b5a870bf74574f45fc46fdccb9551a2e911f360
This commit is contained in:
Felipe Monteiro 2018-03-18 22:59:22 +00:00
parent 831665f59a
commit 354f9d70b2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/policies/snapshots.py
View File

@ -45,11 +45,11 @@ snapshots_policies = [
policy.DocumentedRuleDefault(
name=EXTEND_ATTRIBUTE,
check_str=base.RULE_ADMIN_OR_OWNER,
description="List snapshots with extended attributes.",
description="List or show snapshots with extended attributes.",
operations=[
{
'method': 'GET',
'path': '/snapshots'
'path': '/snapshots/{snapshot_id}'
},
{
'method': 'GET',