This continues moving code only used by volume
drivers or the volume manager to volume_utils.
The result of this is that fewer drivers import
cinder.utils (and everything it imports), and less code
is loaded by non-volume cinder code (api service,
cinder-manage, etc.)
Closes-Bug: #1912278
Change-Id: I5aa82cf0de4c70f53ddc998bf25e64f4ad8f5774
Much of our code renames this at import already --
just name it "volume_utils" for consistency, and
to make code that imports other modules named "utils"
less confusing.
Change-Id: I3cdf445ac9ab89b3b4c221ed2723835e09d48a53
This patch changes the Fibre Channel Zone Manager
utility decorators to functions. Those functions
now have to be called manually. The intention of this
is to unify how the FC drivers are to be declared and
used vs. the iSCSI. No more magic decorators for FC
drivers only.
Change-Id: I8e6e964e3694654b8ba93fe432a0dd49fa5e1df0
When running a replicated service in a cluster, the replication_status
field in the Cluster DB table doesn't get updated in some cases, making
the cluster look like it's non replicated:
- When starting a new clustered replicated service cluster.
- When enabling replication on an already clustered service.
The reason for that is that the service and cluster creation happens on
the Service's __init__ method, while the replication status isn't known
until later, when the start method in the service calls the manager's
init_host_with_rpc, where the manager updates the service DB entry.
This patch adds an update for the replication field to the cluster table
in that same place, making sure we have the right data.
Closes-Bug: #1758024
Change-Id: I0d2fded62372a2fc5f49538133c5b66694dccc77
failover_host is the interface for Cheesecake.
Currently it passes volumes to the failover_host
interface in the driver. If a backend supports both
Cheesecase and Tiramisu, it makes sense for the driver
to failover a group instead of individual volumes if a
volume is in a replication group. So this patch passes
groups to the failover_host interface in the driver in
addition to volumes so driver can decide whether to
failover a replication group.
Change-Id: I9842eec1a50ffe65a9490e2ac0c00b468f18b30a
Partially-Implements: blueprint replication-cg
The SnapshotStatus and SnapshotStatusField have been defined already, This
change just replace the omissive snapshot status string with snapshot enum
field.
Follow up https://review.openstack.org/#/c/284825/
Change-Id: I175398bcad863eaead8b35095d7ff84f9f63aadb
Partial-Implements: bp cinder-object-fields
This patch adds support for replication group.
It is built upon the generic volume groups.
It supports enable replication, disable replication,
failover replication, and list replication targets.
Client side patch is here:
https://review.openstack.org/#/c/352229/
To test this server side patch using the client side patch:
export OS_VOLUME_API_VERSION=3.38
Make sure the group type has group_replication_enabled or
consistent_group_replication_enabled set in group specs,
and the volume types have replication_enabled set in extra specs
(to be compatible with Cheesecake).
cinder group-type-show my_group_type
+-------------+---------------------------------------+
| Property | Value |
+-------------+---------------------------------------+
| description | None |
| group_specs | group_replication_enabled : <is> True |
| id | 66462b5c-38e5-4a1a-88d6-7a7889ffec55 |
| is_public | True |
| name | my_group_type |
+-------------+---------------------------------------+
cinder type-show my_volume_type
+---------------------------------+--------------------------------------+
| Property | Value |
+---------------------------------+--------------------------------------+
| description | None |
| extra_specs | replication_enabled : <is> True |
| id | 09c1ce01-87d5-489e-82c6-9f084107dc5c |
| is_public | True |
| name | my_volume_type |
| os-volume-type-access:is_public | True |
| qos_specs_id | None |
+---------------------------------+--------------------------------------+
Create a group:
cinder group-create --name my_group my_group_type my_volume_type
cinder group-show my_group
Enable replication group on the primary storage:
cinder group-enable-replication my_group
Expected results: replication_status becomes “enabled”.
Failover replication group to the secondary storage.
If secondary-backend-id is not specified, it will go to the
secondary-backend-id configured in cinder.conf:
cinder group-failover-replication my_group
If secondary-backend-id is specified (not “default”), it will go to
the specified backend id:
cinder group-failover-replication my_group
--secondary-backend-id <backend_id>
Expected results: replication_status becomes “failed-over”.
Run failover replication group again to fail the group back to
the primary storage:
cinder group-failover-replication my_group
--secondary-backend-id default
Expected results: replication_status becomes “enabled”.
Disable replication group:
cinder group-disable-replication my_group
Expected results: replication_status becomes “disabled”.
APIImpact
DocImpact
Implements: blueprint replication-cg
Change-Id: I4d488252bd670b3ebabbcc9f5e29e0e4e913765a
The project adheres to PEP 8, so decorators should be named
with underscores (like functions) and not with upper camel
case (like classes)
Change-Id: Ifa38e5d327c2b1a2cdd77ceb2cbc2a9be468bce8
Now each method is wrapped with utils.trace_method to get logs during
tests and debugging if needed.
Change-Id: I2d84716eeb2a528bc2d0cb230fda051704a32737
This patch adds functional tests for groups. It includes the
following tests:
- Create and delete a group
- Create and delete a group snapshot
- Create a group from a group snapshot
- Create a group from a source group
- List and show group and group snapshot
Partial-Implements: blueprint generic-volume-group
Change-Id: If6b139c70e1996ed8db8ea5dff21501adee0f857
Two different fake drivers for unit-tests look confusing. We are able to
test anything we want with only one fake driver.
Current LoggingVolumeDriver doesn't actually log anything. It just
stores all drivers actions in a list.
Now, we can add real logging to FakeLoggingVolumeDriver and use it both
for unit and functional tests.
It's a first patch in a series for unit tests refactoring. More manager
and LVM driver tests will be proposed in a following patches.
Change-Id: I383bcdb531c7d52c0fdbb6875de73f1274a92854
The fake driver is now being used for both unit and
functional tests. It also now has a FakeGate driver to
add some things that aren't supported by all drivers
(including the reference as well as ceph and others).
This patch just moves the fake_driver.py file from
tests/unit to tests as it's not specifically a unit test
object. This isn't a big deal, but makes things a bit more
clear and obvious that there's a useful fake that can be
used in a number of places.
Some of the other fakes could likely be moved as well, but
this one is a start.
Change-Id: Ia5e8608832c0753a4ced8690fa285184c5b8c0c1
This patch moves all of the existing cinder/tests into
cinder unit tests. This is being done to make way for
the addition of cinder/tests/functional.
Yes, this is going to cause significant pain with
any changes that haven't merged behind it in terms
of rebase, but there's no real alternative. We have
to rip the band-aid off at some point, and early in L
seems like a great time to do it.
Change-Id: I63b0f89474b3c139bdb89589abd85319d2aa61ec
H302 PEP8 check should be enabled to make core more clean
and readable and consistent with OpenStack Hacking rules.
Change-Id: Ie189f2418d12800a46664705eacfc127e7269f45
Partial-Bug: #1407162
This patch refactors the LVM Driver to take a
seperate Target object instead of mixing the
control and data path implementations inside the
driver itself.
It removes the volume/iscsi.py and brick/iscsis/*
files which were duplicating code and actually
very messy in terms of where calls were actually
being implemented.
Change-Id: I43190d1dac33748fe55fa00f260f32ab209be656
Placing the _Lx markers back into the code. No other cleaner solution has
has been implemented. Patches will be submitted in a series of sub
directories and in a fashion that is manageable.
eighth commit of this kind
This is the last run through to pick up the ones that were missed
Change-Id: Ifd9d647175a840939bf01fa3bcecfa6384965e3b
Closes-Bug: #1384312
To ensure that logs are properly translated and logged to
the Cinder log files (using the Cinder message catalogs)
we need to explicitly import _() in any python files that
use the _() function.
Closes-bug: 1306275
Related-Blueprint: i18n-enablement
Change-Id: I3cf1f1d63d5f8bd8ffd007104691f914e3fd8538
This patch ensures that the FC ZoneManager
is called during for all cases in Cinder
that does a volume attach/detach for FC
enabled drivers.
The problem was that we had code in the volume
manager that manually called the ZoneManager,
after initialize_connection and terminate_connection,
but other places in Cinder were not calling the
ZoneManager.
This patch creates 2 new decorators that can
be used for any driver's initialize_connection
and terminate_connection call. The decorator
checks to make sure that the return value is for
a fibre_channel attachment and then calls the
ZoneManager's add_connection or delete_connection.
Change-Id: Ie3ae70785f500a140003ad3a8495e0ddc3516ea8
Closes-Bug: 1321798
According to the OpenStack translation policy available at
https://wiki.openstack.org/wiki/LoggingStandards debug messages
should not be translated. Like mentioned in several changes in
Nova by garyk this is to help prioritize log translation.
This patch adds a new hacking check - N319 - that ensures all
debug log messages don't have translations.
Change-Id: Id9c2715f25c8f2ea52235aba4bd1583655391584
Implements: blueprint debug-translation-removal
Closes-Bug: #1318713
1. Adding an API extension to allow clients set volume Read-Only flag on
demand.
2. Require client to provide and be aware of volume attaching mode when
they call 'os-attach' API.
3. Adding a 'access_mode' field to connection info which
'os-initialize_connection' API returned. This field should be used by
client such as Nova to use correct mode accessing attached volume.
Currently access mode can be 'rw' or 'ro'.
4. In future, the driver within Cinder need to ensure the volume be
exposed under the correct access mode which connection info described,
for example backend should set volume to readonly mode when connection
info ask client using 'ro' access mode consume attached volume. That
means Read-Only is not only a attaching mode but also a status for a
volume.
blueprint read-only-volumes
Change-Id: I4c84614d6541d5f7c358abadb957da7b8c3d9c48
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
The new auto-pulled requirements files exposed
python 3 compat issues in a number of modules.
We added these to tox.ini ignore temporarily,
this change updates the print routines in bin/cinder
and removes the debug cruft that was in the unit tests.
Will update requirements and test-requirements
appropriately in a follow up patch.
Change-Id: I76ea24f4dc1f61c4f8a1d202b0554c90daf2c9cc
Refactor the LVM driver to utilize bricks LVM
module. This includes significant modification to
tests and fake objects related to testing.
implements blueprint: refactor-lvm-and-iscsi-driver
Change-Id: I94e41abf90d0c5b77e732d40ed8b81b0a2f5d7dd
Add a clear_volume() method that is called from delete_method().
This is only implemented at present for the base LVM driver.
This new clear_volume() method now supports these config vars:
volume_clear = none, zero, shred
volume_clear_size = size_in_MiB
'zero' is the default method and unchanged from previously.
'none' is used if security isn't a concern, or there is
independent volume scrubbing.
'shred' is for more security conscious situations where
an overwrite count is required. Currently this defaults to 3 passes.
size_in_MiB can be used to limit the cleared area to the first
part of the volume, which can greatly speed up the operation,
and can be useful with encrypted volumes for example where
overwritting the encryption keys at the start is sufficient.
Fixes bug: 1022511
Change-Id: I7312678ff5d66156578501483a1b74e2a69e19a0
Currently volume drivers inherit from VolumeDriver and ISCSIDriver,
which contain LVM-specific code. The LVM-specific functions are
generally overridden. The problem is that there is no place for
generic code for all drivers to inherit, which the LVM driver can
override. This patch basically makes the VolumeDriver and ISCSIDriver
classes mostly empty and moves the LVM-specific code to lvm.py. Also,
moved the global _iscsi_location() and _iscsi_authentication()
functions into the new LVMISCSIDriver class since nobody else used
them.
Change-Id: I067c975de97913bdc39086ad203cddef0c393c7a
Implements: blueprint factor-out-lvm-code
This action calls the same methods nova would after it successfully
detaches a volume. By exposing it to the administrator it makes it's
easier to repair un-syncronized state between services. Generally when
the host is no longer attached, but the volume state is wrong.
Future work: The Iscsi based drivers don't seem to use
initialize_connection and terminate_connection to create the export for
the volume. This would be more useful with drivers that do that.
I added the force parameter to terminate_connection for drivers that may
want to differintiate between a normal terminate and the force detach.
Future Nova work: Nova will want an admin action to update the bdm
tables - today it's a bit of nova-manage shell work.
Change-Id: Icc1cff0f50a5ace9ebdae62c85524ee8d6ec23e0
Moved RBDDriver, SheepdogDriver into their own respective driver
files under cinder/volume/drivers/*. Moved FakeISCSIDriver and
LoggingVolumeDriver into a fake driver file under the tests,
since that's the only place where those are used.
Implements bp driver-cleanup
Change-Id: I39d91ac8e498a9e42c5443db16706203b988444b
Eric Harney