Commit Graph

6 Commits

Author SHA1 Message Date
Chuck Short adcfb4f97e Simplify running pylint
This commit does several things:

- Setup and run pylint directly rather than running
  through a script. This allows the user to see what is happening
  while the user is running through pylint.
- Allow the user to either run pylint on a particular changeset,
  or the entire cinder tree.
- Allow the user to run on a particular changeset. Using like
  HEAD~1, etc.
- Since the pylint gate check I disabled the tests that were
  reported by pylint. The thought here would be go through
  the failures and correct them.
- Update pylint to 2.1.1.
- Removed old pylintrc.

Change-Id: I708c93843d991e8c0ac114b0b2d6ede373b96d0a
Signed-off-by: Chuck Short <chucks@redhat.com>
2018-09-06 10:00:07 -04:00
Victor Stinner f484310fe6 Use six to fix imports on Python 3
Replace Python 2 imports with six.moves import to make code compatible
with Python 2 and Python 3.

Replaced imports:

* BaseHTTPServer
* __builtin__
* cookielib
* httplib

This patch was generated by the six_moves operation of the sixer tool
version 0.4:
https://pypi.python.org/pypi/sixer

Manual changes:

* Disable pylint warnings on the HTTPSConnection classes because pylint
  doesn't support importing from six.moves yet, see:
  https://bitbucket.org/logilab/pylint/issue/550/

Blueprint cinder-python3
Change-Id: Ide6d4e3480f2c0a7eb4500aa88affe152ecc0401
2015-06-11 17:19:19 +02:00
Martin Kletzander 22500e94cd Fix common misspellings
Wikipedia's list of common misspellings [1] has a machine-readable
version.  This patch fixes those misspellings mentioned in the list
which don't have multiple right variants (as e.g. "accension", which can
be both "accession" and "ascension"), such misspellings are left
untouched.  The list of changes was manually re-checked for false
positives.

[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Change-Id: I44d53a807a6d2e9910daab939f4c0b7768c07ad9
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2015-05-11 13:12:32 +02:00
Mike Mason d499f57d25 Amend unused variables to assist pylint testing
Amedning unused variables with a prefix of an underscore to prevent them
being picked up in pylint testing, consistency, and for general housekeeping.
Change to pylintrc also required to enforce the rule.

Closes-bug #1268062

Change-Id: I80c2cbdc52d6f37823fae90d0096836166412643
2014-10-30 16:23:57 +00:00
Duncan Thomas 9bcbf5e50e Remove outdated _ as a builting from pylintrc
Closes-bug: #1383302
Change-Id: I35e73fcabf39a01b667d570478227c960e1c450c
2014-10-20 14:37:36 +01:00
Jenkins c53d8e343e Initial fork out of Nova. 2012-05-03 10:48:26 -07:00