openstack
/
cliff
Code Issues Proposed changes

Removed unused err variable 

Frankly I don't know why this is now a problem but pep8 is failing[1] with:

  cliff/app.py:403:9: F841 local variable 'err' is assigned to but never used

It looks to me like the 'err' in the except path is causing this to be
shadowed and unused?

[1] http://logs.openstack.org/18/614218/2/check/openstack-tox-pep8/9930eb3/job-output.txt.gz#_2018-10-30_16_34_38_436438

Change-Id: I4760942aef3e41fbaeabb8e88ac198fff3dfb709
This commit is contained in:
Tony Breeds 2018-10-31 08:54:30 +11:00
parent 20dcb2fefc
commit 686f876b02
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cliff/app.py
View File

@ -389,7 +389,6 @@ class App(object):
if 'cmd_name' in utils.getargspec(cmd_factory.__init__).args:
kwargs['cmd_name'] = cmd_name
cmd = cmd_factory(self, self.options, **kwargs)
err = None
result = 1
try:
self.prepare_to_run_command(cmd)