summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorSamuel Cassiba <s@cassiba.com>2017-07-11 06:19:21 -0700
committerSamuel Cassiba <s@cassiba.com>2017-08-02 02:15:54 -0400
commitd2ff4496bbbd52cfeeef05cc4d39217da69d5b23 (patch)
tree05ad0ed2d80c6b7d7648461a0a29bbda26196876 /spec
parentae28e7479350682671ae8f57d186cd3d6d9d0394 (diff)
Added systemd unit, style and lint fixes for chefdk
- cinder-group-active is still SysV, but can and will start via systemd if coaxed to do so. - Style and lint fixes for newer chefdk - Removed ancient Gemfile - Rewrote metadata.rb for readability Change-Id: I4c26aea78220eb20fc4e5e964af93414855df5f6
Notes
Notes (review): Code-Review+2: Christoph Albers <c.albers@x-ion.de> Code-Review+1: Tovin Seven <vinhnt@vn.fujitsu.com> Workflow+1: Jan Klare <j.klare@cloudbau.de> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 10 Aug 2017 13:18:23 +0000 Reviewed-on: https://review.openstack.org/482563 Project: openstack/cookbook-openstack-block-storage Branch: refs/heads/master
Diffstat (limited to 'spec')
-rw-r--r--spec/api_spec.rb3
-rw-r--r--spec/cinder_common_spec.rb8
-rw-r--r--spec/spec_helper.rb2
-rw-r--r--spec/volume_spec.rb2
4 files changed, 8 insertions, 7 deletions
diff --git a/spec/api_spec.rb b/spec/api_spec.rb
index 0233a84..366a2bb 100644
--- a/spec/api_spec.rb
+++ b/spec/api_spec.rb
@@ -45,7 +45,8 @@ describe 'openstack-block-storage::api' do
45 expect(chef_run).to create_remote_file('/etc/cinder/policy.json').with( 45 expect(chef_run).to create_remote_file('/etc/cinder/policy.json').with(
46 user: 'cinder', 46 user: 'cinder',
47 group: 'cinder', 47 group: 'cinder',
48 mode: 00644) 48 mode: 0o0644
49 )
49 end 50 end
50 end 51 end
51 end 52 end
diff --git a/spec/cinder_common_spec.rb b/spec/cinder_common_spec.rb
index d912040..2a11540 100644
--- a/spec/cinder_common_spec.rb
+++ b/spec/cinder_common_spec.rb
@@ -28,7 +28,7 @@ describe 'openstack-block-storage::cinder-common' do
28 expect(chef_run).to create_directory(dir.name).with( 28 expect(chef_run).to create_directory(dir.name).with(
29 owner: 'cinder', 29 owner: 'cinder',
30 group: 'cinder', 30 group: 'cinder',
31 mode: 00750 31 mode: 0o0750
32 ) 32 )
33 end 33 end
34 end 34 end
@@ -46,7 +46,7 @@ describe 'openstack-block-storage::cinder-common' do
46 expect(chef_run).to create_template(file.name).with( 46 expect(chef_run).to create_template(file.name).with(
47 owner: 'cinder', 47 owner: 'cinder',
48 group: 'cinder', 48 group: 'cinder',
49 mode: 00640 49 mode: 0o0640
50 ) 50 )
51 end 51 end
52 52
@@ -185,7 +185,7 @@ describe 'openstack-block-storage::cinder-common' do
185 expect(chef_run).to create_directory(dir.name).with( 185 expect(chef_run).to create_directory(dir.name).with(
186 user: 'cinder', 186 user: 'cinder',
187 group: 'cinder', 187 group: 'cinder',
188 mode: 00755 188 mode: 0o0755
189 ) 189 )
190 end 190 end
191 end 191 end
@@ -197,7 +197,7 @@ describe 'openstack-block-storage::cinder-common' do
197 expect(chef_run).to create_template(file.name).with( 197 expect(chef_run).to create_template(file.name).with(
198 user: 'root', 198 user: 'root',
199 group: 'root', 199 group: 'root',
200 mode: 0644 200 mode: 0o644
201 ) 201 )
202 end 202 end
203 203
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 029cfa8..061067c 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -98,7 +98,7 @@ shared_examples 'creates_cinder_conf' do |service, user, group, action = :restar
98 expect(chef_run).to create_template(file.name).with( 98 expect(chef_run).to create_template(file.name).with(
99 user: user, 99 user: user,
100 group: group, 100 group: group,
101 mode: 0640 101 mode: 0o640
102 ) 102 )
103 end 103 end
104 104
diff --git a/spec/volume_spec.rb b/spec/volume_spec.rb
index acf38eb..5c6b3b2 100644
--- a/spec/volume_spec.rb
+++ b/spec/volume_spec.rb
@@ -54,7 +54,7 @@ describe 'openstack-block-storage::volume' do
54 54
55 it 'should create the targets.conf' do 55 it 'should create the targets.conf' do
56 expect(chef_run).to create_template(file.name).with( 56 expect(chef_run).to create_template(file.name).with(
57 mode: 0600 57 mode: 0o600
58 ) 58 )
59 end 59 end
60 60