summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorRoger Luethi <rl@patchworkscience.org>2017-11-10 10:31:06 +0100
committerRoger Luethi <rl@patchworkscience.org>2017-11-10 10:31:06 +0100
commite5e8bb9326fb808ac8d3e20d615a71cd959bf49d (patch)
tree48c16728dd22956f4df011849b1606fa858ebb57 /spec
parentdb13c39007e272e936898fc2dbd9cfc6c7da24a9 (diff)
Remove superfluous role_name arguments
This patch removes the role_name when using openstack_user's :create action (it gets ignored by the target method). Note that the spec test would still pass if only the line in identity_registration.rb (but not the test) were changed, because the code that actually does grant the role to the resource is executed right after user creation and before any tests check the resource for the existence of the role_name attribute. In other words: if the argument were required in a call but only supplied in another call, the spec tests would not catch it. Something to watch out for. Change-Id: I320d0e85287aa5d6368d5be323999f8d9e1c462f
Notes
Notes (review): Code-Review+2: Christoph Albers <c.albers@x-ion.de> Code-Review+2: Samuel Cassiba <s@cassiba.com> Workflow+1: Samuel Cassiba <s@cassiba.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 17 Nov 2017 17:44:04 +0000 Reviewed-on: https://review.openstack.org/519376 Project: openstack/cookbook-openstack-block-storage Branch: refs/heads/master
Diffstat (limited to 'spec')
-rw-r--r--spec/identity_registration_spec.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/spec/identity_registration_spec.rb b/spec/identity_registration_spec.rb
index f588379..e839d1b 100644
--- a/spec/identity_registration_spec.rb
+++ b/spec/identity_registration_spec.rb
@@ -74,7 +74,6 @@ describe 'openstack-block-storage::identity_registration' do
74 service_user 74 service_user
75 ).with( 75 ).with(
76 project_name: project_name, 76 project_name: project_name,
77 role_name: role_name,
78 password: password, 77 password: password,
79 connection_params: connection_params 78 connection_params: connection_params
80 ) 79 )