- cinder-group-active is still SysV, but can and will start via systemd if
coaxed to do so.
- Style and lint fixes for newer chefdk
- Removed ancient Gemfile
- Rewrote metadata.rb for readability
Change-Id: I4c26aea78220eb20fc4e5e964af93414855df5f6
- deprecated Gemfile
- Updated TESTING.md and README.md
- updated Rakefile to use chef exec insted of bundle exec
- replaced Runner with SoloRunner in specs
Change-Id: If3e3b54c9dbaa8bb51164bc85fd93ff5fc54ec4d
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: If366dff9394f416b0704bea89ae50c1c472606bf
blueprint: rakefile
Updated berkshelf from 2.0.18 to 3.1.5 in Gemfile and added supermarket
source to Berksfile
Change-Id: I76a16fb6fb9fd4743027fb22403eacbda09647ce
Implements: blueprint update-berkshelf
This change gives us new capabilities, such as matching notifies and
subscribes of resources.
Implements: blueprint chefspec-3-4
Change-Id: If9c4e70f4b3e99cf75bb595ca577be01a072eced
The fauxhai fix for the cpu stanza has merged and is available in
fauxhai version 2.1.0 so reverting the workaround patch and ensuring
fauxhai 2.1.0 is used.
- Remove the node.set for ['cpu']['total']
- Adjust the Gemfile to use fauxhai 2.1.0
- Adjust the Gemfile.lock
Change-Id: Ib1fc86af1306d5443721400589a8c830263c0767
Addresses: blueprint fauxhai-cleanup
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Add Includes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: I9224b785f50103d348e3b16ea24e5dc8cab84c62
Implements: blueprint lint-and-unit-testing-for-havana
Consolidate all the .rubocop.yml into a single file, finished out cleanups for
all the Ruby files.
Change-Id: I92d5983724d5d0185cd25bea6a0f46657a6c05d4
Addresses: blueprint rubocop-for-block-storage
Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy. So far this is just spacing issues and adding UTF-8 headers, but more
work will need to be done to remove all of the changes for the .rubocop-todo.yml
Change-Id: I590ac5ec03ce6a00dd73027d6798e36105a32af1
Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy.
rubocop | 24 files inspected, 1617 offences detected
Change-Id: I10077146fbaa015c4b74cac826761de273c5639d
This is a much clearer way to test LWRPs are executed with
the proper options. The previous approach was hacky, and
relied upon too much stubbing and ruby magik. Also, updated
to berkshelf 2.0 where Berksfile.lock is respected. This
is necessary for berkshelf to lock to the proper cookbook
deps in openstack's CI system.
Change-Id: I21c1c000581f2d3c94ff2f9628f0cea0f6536013
ChefSpec 1.3.0 allows tests to evaluate guards. Wired in
this cookbook to use that functionality. Made tests a
bit clearer, and better utilize the block_storage_stubs.
Change-Id: Ib2e3ee8e00bdc5fb5dcda6b48beb0c405e9d8b92
Also add dependency on json <= 1.7.7, required by Chef 11.
Resolves problem: Bundler could not find compatible versions for gem
"json" (required for chef and berkshelf).
Partial fix for bug #1183540
Change-Id: Ia10a0256b782eafe70363e737f4f79ce2bb8be82
Samuel Cassiba