update python-openstackclient version

- update python-openstackclient version from 2.6 to 3.4.1
- minor style changes in spec
- moved python-openstackclient version to node attribute

Change-Id: If9ffbc539ebca7de222dc25205d9f760a774412b

attributes/default.rb

@@ -26,6 +26,9 @@ default['openstack']['common']['custom_template_banner'] = '
 # Do not edit, changes will be overwritten
 '
 
+# version for python-openstackclient
+default['openstack']['common']['client_version'] = '3.4.1'
+
 # OpenStack services and their project names
 default['openstack']['common']['services'] = {
   'bare-metal' => 'ironic',

recipes/client.rb

@@ -21,5 +21,5 @@
 python_runtime '2'
 
 python_package 'python-openstackclient' do
-  version '2.6'
+  version node['openstack']['common']['client_version']
 end

spec/client_spec.rb

@@ -9,13 +9,13 @@ describe 'openstack-common::client' do
       runner.converge(described_recipe)
     end
 
-    it 'installs the latest python 2' do
+    it do
       expect(chef_run).to install_python_runtime('2')
     end
 
-    it 'installs python-openstackclient 2.6' do
+    it do
       expect(chef_run).to install_python_package('python-openstackclient')
-        .with(version: '2.6')
+        .with(version: '3.4.1')
     end
   end
 end