- Cookstyle fixes
- Refactor Berksfile to use groups so we can exclude integration testing
cookbooks
- Update documentation
- Cleanup line wraps
- Enable sensitive resources for the template[/etc/neutron/neutron.conf] and
template[/etc/neutron/metadata_agent.ini] to resources improve security.
- Update delivery configuration to exclude integration cookbooks
- Fix ChefSpec output.
- Update lbaas recipe to use v2 agent driver.
- Add recommended configuration settings to neutron.conf based in Stein
installation docs.
- Remove any resources that define the default action.
- Switch package installations to send packages as arrays instead of individual
package resources. This generally speeds up chef runs.
- Manage /etc/neutron/neutron_lbaas.conf so we can set service_provider
properly.
- Add some missing ChefSpec tests.
- Configure neutron_lbaas.conf on Ubuntu in a manner that allows it to properly
pull in the configuration via the --config-dir option. This is due to the fact
we need to set an additional [service_providers] service_provider line and we
can't do that with hashes.
- Remove FWaaS as it's unmaintained upstream.
Depends-On: https://review.opendev.org/701027
Depends-On: https://review.opendev.org/706151
Change-Id: Id29884766440d37fa18fd62f3f93eecc22224d51
- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
Change-Id: I5dd1971392fdf282d0f214dfce9dcbecc18542a8
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: Iccc37e0fd46323f1f19bee32bda0a7a3ee8c3974
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop enforces
an underscore '_' every 3 characters of an integer. This doesn't make much
sense in our use case and reduces readability. Especially for port numbers.
- Remove any existing entries that were abiding by the NumericLiterals
cop.
Change-Id: I4dd9485c0defcf896945f805ca8897011c0424ab
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Add Includes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: Ib3220a0ab8281bc0eafaf9898c233d90490cfde6
Implements: blueprint lint-and-unit-testing-for-havana
- Update .rubocop.yml to include spec/**
- Update spec files to be rubocop compliant
- Inlcude 'chefspec/berkshelf' in spec_helper.rb for ease of use
Change-Id: Ief01cc34cc4f9f04e6ba6437f67bfd347975c3a8
Addresses: blueprint rubocop-for-network
all cops now pass except for the following
(which are silenced in .rubocop.yml )
* LineLength, MethodLength: not sure if we care about these
* WordArray: I prefer [] vs %w{} for readability.
Conflicts:
metadata.rb
recipes/common.rb
recipes/openvswitch.rb
spec/openvswitch_spec.rb
Change-Id: I92996b5db9f292e9ba93c7619ca727ffa92ddd71
https://blueprints.launchpad.net/openstack-chef/+spec/lint-and-unit-testing-for-havana
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md. Will
remove the .rubocop-todo.yml once the rest of the Rubocop support is filled out
* updating chefspec to 3.1.4 (for chefspec coverage)
Addresses: blueprint rubocop-for-network
Change-Id: I9c9c5b48f3e1174b1e7ec7b5451a6ad9fd82b5e0