No need to push our rabbit user/pass to rabbit cookbook

Because the rabbit user/pass is stored in internal user database,
no need to push them to rabbit cookbook and expose them in config file.
And configuring rabbitmq default password with clear test is insecure,
so remove it.

Change-Id: Iab95e2dc8cd28b4a45574cf8883f1626dc332db0
Closes-Bug: #1381343

CHANGELOG.md

@@ -6,6 +6,7 @@ This file is used to list changes made in each version of cookbook-openstack-ops
 * Configure rabbitmq port for both ssl and non-ssl cases
 * Fix metadata version constraint for common
 * Bump Chef gem to 11.16
+* No need to push our rabbit user/password to rabbit cookbook
 
 ## 10.0.0
 * Upgrading to Juno

recipes/rabbitmq-server.rb

@@ -43,8 +43,6 @@ else
   node.override['rabbitmq']['port'] = rabbit_endpoint.port
 end
 node.override['rabbitmq']['address'] = listen_address
-node.override['rabbitmq']['default_user'] = user
-node.override['rabbitmq']['default_pass'] = pass
 
 # Clustering
 if node['openstack']['mq']['cluster']
@@ -59,6 +57,8 @@ end
 include_recipe 'rabbitmq'
 include_recipe 'rabbitmq::mgmt_console'
 
+# TODO(mrv) This could be removed once support for this is added to the rabbitmq cookbook.
+# Issue: https://github.com/kennonkwok/rabbitmq/issues/136
 rabbitmq_user 'remove rabbit guest user' do
   user 'guest'
   action :delete

spec/rabbitmq-server_spec.rb

@@ -15,8 +15,6 @@ describe 'openstack-ops-messaging::rabbitmq-server' do
       expect(chef_run.node['openstack']['mq']['rabbitmq']['use_ssl']).to be_falsey
       expect(chef_run.node['rabbitmq']['port']).to eq(5672)
       expect(chef_run.node['rabbitmq']['address']).to eq('127.0.0.1')
-      expect(chef_run.node['rabbitmq']['default_user']).to eq('guest')
-      expect(chef_run.node['rabbitmq']['default_pass']).to eq('rabbit-pass')
       expect(chef_run.node['rabbitmq']['use_distro_version']).to be_truthy
     end