- Cookstyle fixes
- Refactor Berksfile to use groups so we can exclude integration testing
cookbooks
- Update documentation
- Cleanup line wraps
- Enable sensitive resources for the template[/etc/heat/heat.conf] to
resources improve security.
- Update delivery configuration to exclude integration cookbooks
- Fix ChefSpec output.
- Add missing ChefSpec tests
- Switch package installations to send packages as arrays instead of individual
package resources. This generally speeds up chef runs.
- Cleanup array syntax using %w() instead of []
Depends-On: https://review.opendev.org/701027
Depends-On: https://review.opendev.org/706101
Depends-On: https://review.opendev.org/706151
Depends-On: https://review.opendev.org/706157
Depends-On: https://review.opendev.org/708059
Depends-On: https://review.opendev.org/713285
Change-Id: Ifb3a9de9eecc370e46f43a73ed77008a7b21594b
- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
- Normalized template banner
Change-Id: Icc3eca4b2d17a6d1ef66c1c7e75513de0ee3cac9
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: Ia4d52047f1f20b4a62fd1c3726389f3ad562a968
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop enforces
an underscore '_' every 3 characters of an integer. This doesn't make much
sense in our use case and reduces readability. Especially for port numbers.
Change-Id: I32617941e3ee1f43e06fb5b9017e6ccab0cf5050
Addresses: blueprint rubocop-integer
It appears orchestration was missing in the rubocop blueprints. Bringing it
up to par with the other cookbooks.
- Update rubocop config to include spec/**
- Update specs to comply with rubocop
- Delete unused default spec file
Change-Id: Ie96c16fc82a4ca2c04e20fc7db2b036937f0ba04
It appears orchestration was missing in the rubocop blueprints. Bringing it
up to par with the other cookbooks.
- Update rubocop config to include recipes/**
- Update recipes to comply with rubocop
Change-Id: I17a4ee2378bac48cda0b96ae6ad4f9db8916f1b6
Ghanshyam Mann