- Cookstyle fixes
- Refactor Berksfile to use groups so we can exclude integration testing
cookbooks
- Update documentation
- Cleanup line wraps
- Enable sensitive resources for the template[/etc/aodh/aodh.conf],
template[/etc/gnocchi/gnocchi.conf] and
template[/etc/ceilometer/ceilometer.conf] to resources improve
security.
- Update delivery configuration to exclude integration cookbooks
- Fix ChefSpec output.
- Add missing ChefSpec tests
- Switch package installations to send packages as arrays instead of individual
package resources. This generally speeds up chef runs.
- Cleanup array syntax using %w() instead of []
Depends-On: https://review.opendev.org/701027
Depends-On: https://review.opendev.org/706101
Depends-On: https://review.opendev.org/706151
Change-Id: I73e3c3dce64798a4d6ba5c94cc45dfabc4d2d0ff
- Switched default linter to cookstyle
- Renamed rake tasks to better conform with Chef conventions
- Normalized template banner
Change-Id: If802d82561619a0b7951422dc0e1e913f2c4c8b4
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.
This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).
There is also a :clean task to help with deleting the files generated by
the other jobs.
Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. https://github.com/berkshelf/berkshelf/issues/931#issuecomment-29668369
Change-Id: If76f6fca62c7cff719e9a631c968a252cf30f10a
blueprint: rakefile
- Disable the NumericLiterals cop in the .rubocop.yml file - this cop enforces
an underscore '_' every 3 characters of an integer. This doesn't make much
sense in our use case and reduces readability. Especially for port numbers.
Change-Id: Id4668757f304ca6fe3e7f0809c917f30cfa07636
Addresses: blueprint rubocop-integer
Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.
- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
automatically cover future additions
Change-Id: I62cb43675f56469cefaa480e5043514741bedb04
Implements: blueprint lint-and-unit-testing-for-havana
- Remove directory/.rubocop.yml files
- Adjust Strainerfile to use the single .rubocop.yml
- Adjust .rubocop.yml ot reference all directories
Change-Id: I4323a1d1b626001c0b0dc05bec473b16c637f485
Addresses: blueprint rubocop-for-metering
Ghanshyam Mann