This commit is part of a series to retire the Packaging Deb
project. Step 2 is to remove all content from the project
repos, replacing it with a README notification where to find
ongoing work, and how to recover the repo if needed at some
future point (as in
https://docs.openstack.org/infra/manual/drivers.html#retiring-a-project).
Change-Id: I6ca27a94cfb35256d71966ea300245365d210350
Some minor formatting issues caused by openstackdocstheme adoption
in README.rst and HACKING.rst.
Note that the install instruction is part of README, so it is not split
out into a separate rst file (as suggested in the doc-migration spec).
Change-Id: Iac58eeb15921e9225a461e3b5b2f3bd7ac99f415
Python 3.3/Python 2.6 is not supported from Mitaka, as per Infra.
This patch removes the support for the same.
Change-Id: Ib0c93920cc785b1f4708d6f8d3b75e775793ba6a
Adding constraints support to libraries is slightly more complex than
services as the libraries themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.
This change adds constraints support by also adding a helper script to
edit the constraints to remove hacking.
Change-Id: Id01984f5a986cf84a8fff3f028bb6246364ea2ff
Today hacking only provides consumers specifying the local check
factory function via tox.ini (in the '[hacking]' section). While this works
fine in a number of cases, others need a way to specify multiple
check factories without using multiple tox.ini files.
For example, we'd like a library project to define a common set of hacking
check functions for consumers. Some of those factory functions
may register checks we want consumers to run in 'warn only' mode.
From a tox.ini perspective, we'd like to be able to do this:
[testenv:pep8]
commands =
# run mandatory checks in fail mode
flake8 --factory a.b.c.mandatory
# run incubating checks in warn-only mode
flake8 --factory a.b.c.incubating --exit-zero
Today the above isn't possible without 2 separate tox.ini files;
each to specify the local-check-factory. While we can use our
own flake8 extension [1], it would be better to have this
support built right into hacking enabling a broader set of use
cases.
This patch adds a CLI option called --local-check-factory that
allows consumers to pass a local-check-factory via CLI. If
specified on CLI, it overrides anything in tox.ini. Using this
patch consumers can achieve the use case noted above and this
should also be backwards compatible.
[1] https://review.openstack.org/#/c/350723/14/neutron_lib/hacking/checks.py@286
Change-Id: I26f68e11d21938a13974c4e7684eea604dfc2e69
It is recommended to use
assert{Greater,GreaterEqual,Less,LessEqual,Equal,NotEqual} rather than
assertTrue(comparison).
Change-Id: Idd57a5e7897b839707371033d7f25604d44e9cd9
Releasenote translation publishing is being prepared. 'locale_dirs'
needs to be defined in conf.py to generate translated version of the
release notes.
Note that this repository might not get translated release notes - or
no translations at all - but we add the entry here nevertheless to
prepare for it.
Change-Id: I52264fdacde1a2e45d390afb681824b70b23f552
When doing a test using pycodestyle instead of pep8, a few errors were
reported.
Fix those errors so it passed the tests.
Change-Id: I8e280aeab0575bd5a0919cbe4b9292df51c987ed
...instead of assertEqual(None, ...) or assertIs(None, ...) and their
negations.
Apparently that's a thing that people want? At any rate, 30+ projects
have this bug marked "Fix Released". However, without a check to keep
them from regressing, there is a long tail of follow-up patches that
distracts developers and reviewers from addressing user-facing bugs. See
the following Nova changes, spread out over the course of a year, for an
example:
If3824356ddf4e6e2d91f6bc2fbfa41946d8463cc
I09f38e219931e0d7ad27f04861d1ebbc3b5e2c5f
Iee1379b941f93388900e89388676000b845fc8fc
I0d38a82e78fbe94657ab9a71c08422007843d179
I9316c0b125aa87b6ebfa996a559c3551093ea711
I406ea23b0e78f45f16306813e4111a95716cd6b0
Ic8cb1192e001409d827c8da55fe536681895944b
Add a check for it in the interest of not wasting reviewer time or
having more code churn than necessary.
Change-Id: Iad65cb6399f4f933cbd9f503c88ce144387d39b5
Related-Bug: #1280522
Releasennotes build fails with:
WARNING: html_static_path entry
u'/home/aj/vcs/OpenStack/openstack-dev/hacking/releasenotes/source/_static'
does not exist
ERROR: InvocationError:
'/home/aj/vcs/OpenStack/openstack-dev/hacking/.tox/releasenotes/bin/sphinx-build
-a -E -W -d releasenotes/build/doctrees -b html releasenotes/source
releasenotes/build/html'
Add - like in other projects - the directory using a placeholder file to
make git happy.
Change-Id: Ic012f5d02dbe8ecea30b7c6a10a94199dc5e809f
Flake8 3.0 enforces the check signature contract that was detailed in
2.x. To prepare Hacking for Flake8 3.0's release, we need to clean up
our signatures and stop requesting both logical_line and physical_line,
especially when we don't use both in each of those cases.
Change-Id: Id55eadb66599a9bf240c837dafa88737aa024a16
Closes-bug: 1597729
Update the link, the current one is 404.
Change-Id: If37ffc98909e0c1fc8a320d62b18c64a8983a797
Signed-off-by: Nattaphoom Chaipreecha <attomos@gmail.com>
This adds a placeholder file (like every other project has by default),
the source for the sphinx-generated release notes project, and the
appropriate requirements and tox environments.
Change-Id: I999b4f7014216361ba559158b13d776531dc8591
We need to update our flake8 dependency version so we can use
--allow-extensions to be used with our off-by-default rules.
Change-Id: I3171244a14ebc110f2b041b9db75499f007f472b
Tony Breeds