As Python 2.7 will soon reach the end of life, we should switch to
Python 3.
This updates the tests to run with that version.
Change-Id: I1014769881786c62d9d6aabf21ca7858a6deb882
There is an issue with the ostestr package that it sends a 'None' value
if it is not explicitly specified.
The stestr package does not accept it well, and an exception is thrown.
There is a fix in the pipe [1], but we need to get DragonFlow working.
[1] https://review.opendev.org/#/c/651275/
Change-Id: If9d18965048cc5ac20d351b7172b50d0a1d0f2cc
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: Idd0dd8b137f6cbf22cbb706645488271b0e5cee5
This patch adds local tox targets for pep8 and python 3 as per [1]
that will install dependencies in editable mode.
To run them use the pep8-dev and py3-dev targets respectively.
[1] https://etherpad.openstack.org/p/neutron-sibling-setup
Change-Id: Ie2250722473b150e0c56dce0da220c615df51c34
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I91abb5cb2e945abae630b07b1929ce1834d0d93d
This patch adds doc8 check for .rst files to pep8.
Files that fail doc8 check are also fixed.
Ignore D001 of doc8 check. This requires lot of changes and
should be done in a separated patch.
Change-Id: Ie2d258e9268fe20ae7988a3b4af92a8a6973b9c6
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: I06a45ffdb95e4c79edeca179254f25252d9fef6e
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I7471f66742e4c843321d771408d0da67d9800da1
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Since neutron and networking-sfc are now in global-requirements,
we can remove the installation from tools/tox_install.sh.
Remove the tox_install files completely and update tox.ini for this.
Add requirements to requirements.txt instead.
Change-Id: Id6d43a97bd77785de976d418dc835108e3b1434f
This patch enable extensions:
- H204: Use assert(Not)Equal to check for equality.
- H205: Use assert(Greater|Less)(Equal) for comparison.
Change-Id: I55240cc648385554dd67dc62d6749cef6c59dd70
rm is used to remove times.dbm between tests of py27 and py35. It should
be in whitelist_externals to avoid the warning:
WARNING:test command found but not installed in testenv
cmd: /bin/rm
env: /home/oanson/projects/dragonflow-2/.tox/py27
Maybe you forgot to specify a dependency? See also the whitelist_externals
envconfig setting.
Change-Id: I3ebe98f6cc17dced84621c6f089b4f04bb1a2300
Closes-Bug: #1711152
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, like the one making the gate fail
if for some reason no tests are executed because all of them are
skipped.
Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
The gating on python 3.4 is restricted to <= Mitaka. This is due
to the change from Ubuntu Trusty to Xenial, where only python3.5
is available. There is no need to continue to keep these settings.
Change-Id: Ie516ade5312592ce39e4c27e0e694713c0946082
The exclude list of flake8 is out of date. Update it with latest
project structure.
Change-Id: I74bbb234843226a75be81f2662fa6d983644b0f4
Closes-Bug: #1663864
Unlike E126, which is controversial, E128 is a check should be applied
to code.
E128 continuation line under-indented for visual indent
Change-Id: Idc67968dcc424e8eef252fff1704c96d32fe452a
Partial-Bug: #1663864
H904: Delay string interpolations at logging calls, which is the
former N342, prevents format string when add log. Enabling it can
uniform the way we do log.
Change-Id: I4d16a7db530d9fa5a641140e03680307f878f0bb
Partial-Bug: #1663864
[H301] Do not import more than one module per line (*)
is now in the ignore list of dragonflow pep8 check. However,
[1] and some following work has cleaned the dragonflow import code.
So, we can add the check in pep8 for future code.
[1] https://review.openstack.org/#/c/360956/
Change-Id: Ib583f8be57cc1976d868433613f70378d8809f0d
Partial-Bug: #1663864
Current N342 is the nova check for central conf files.
[N342] Config options should be in the central location nova/conf/
We can just remove it from the ignore list. Hopefully, future rule
will be added in neutron-lib for such check in networking project.
Change-Id: Ib4d3eadeb100ea26f7ccfeaca14a219c29e43c2e
Partial-Bug: #1663864
H233 will report error when print is used as operator.
print operator has been removed in py3. We should add H233 check
as py3 is in the support list. This problem was first found at [1]
We can launch the check for future code.
[1] https://review.openstack.org/#/c/396915/
Change-Id: I4fef99c24941f048fd61a808e03869bacd30c001
Co-Authored-By: Wang Jian <wangjian38@huawei.com>
Partial-Bug: #1663864
You can run 'tox -ereleasenotes' to generate the doc.
Currently it is nearly empty. We can decide when to make it
work in our release cycle management.
Change-Id: I13506a3f654265262a0696f85d0c4c94835ee0ee
The current coverage test job doesn't provide any result
to developer, we could endble the coverage report in
console output to let the developers know the current
coverage status when run coverage test job.
Change-Id: Id6f884ca8dfcc9dfa01f7b827786f4fa41b461a4
1. Removes centralized_dragonflow from index (learned in
last meeting that this isn't a scope for df)
2. Fixes duplicated diagram
3. Fixes reason for last warning.
Fixes sphinx warnings and errors.
1. Change image references to local paths.
2. Fix underline too short issues.
3. Fix numbered/unnumbered lists.
4. Fix unindented ascii art
5. Fix line break issues
6. Fix naming typo in index.rst
There is still a reference to an unknown document in
source/index.rst (centralized_dragonflow).
Change-Id: I5165d4efa0644470c90adfbc606daabfbf55292f
The directory openstack/common was used to keep codes from
oslo-incubator, we have retired oslo-incubator,so don't use
this directory any more.
Change-Id: I5ad7b717be1ddbbe53b6d0f787b7aba02f3290d4
Neutron forbid to import neutron.test at [1]. As a sub-project, dragonflow
still needs neutron.test as lib for its own test. sub-project should use a
more general hacking rule from neutron-lib.
[1] 31e1aeb66b2d8abb0d8424e9550693fad6f37c1c
Change-Id: I7150203324eecc58ab37b25b0fc473ae2a07fe4d
Sean McGinnis