summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Krotscheck <krotscheck@gmail.com>2016-03-01 09:42:28 -0800
committerMichael Krotscheck <krotscheck@gmail.com>2016-03-01 09:42:28 -0800
commit1c762b492307a2609835742f073d552744e14c77 (patch)
tree694ff52800d70db3ffb22a8b8c9bdc47d2da1d4a
parentc16449948069c8a6f0202188bf20b3931a8d0cb1 (diff)
Clarified wording in governance
This patch clarifies the wording on a few governance statements. First, the intent of the rule approval policy is to encourage more pairs of eyeballs - thus the wording was changed from +5 to 'five positive votes'. Secondly - library upgrades should _never_ change the existing rule set, because they already impose changes due to bugfixes in the rules themselves. Change-Id: I4f2765bcd04cb50da94ac121259c0cc8244bda19
Notes
Notes (review): Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+1: Itxaka Serrano Garcia <itxaka@redhat.com> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Wed, 04 May 2016 19:54:32 +0000 Reviewed-on: https://review.openstack.org/286740 Project: openstack/eslint-config-openstack Branch: refs/heads/master
-rw-r--r--README.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/README.md b/README.md
index 4c0f26f..30dce4e 100644
--- a/README.md
+++ b/README.md
@@ -21,11 +21,11 @@ If you would like to contribute, please follow [OpenStack's contribution guideli
21 21
22#### Rules only land with consensus 22#### Rules only land with consensus
23Patches that activate, deactivate, or modify rules, should only be merged if a consensus of 23Patches that activate, deactivate, or modify rules, should only be merged if a consensus of
24reviewers is reached. In this case, consensus means at least five +1 votes, with no -1 votes. Cores 24reviewers is reached. In this case, consensus means at least five positive votes (+1 or +2),
25may not override and/or ignore -1 votes. 25with no -1 votes. Cores may not override and/or ignore -1 votes.
26 26
27#### Library upgrades require two cores 27#### Library upgrades require two cores
28Patches that upgrade eslint only require two core approvers to land. These patches should add new 28Patches that upgrade eslint only require two core approvers to land. These patches must add new
29upstream rules in a deactivated state, and delete any deprecated rules. 29upstream rules in a deactivated state, and delete any deprecated rules.
30 30
31#### Policy upgrades require all cores 31#### Policy upgrades require all cores