summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVitaly Kramskikh <vkramskikh@mirantis.com>2016-05-12 18:23:18 +0300
committerVitaly Kramskikh <vkramskikh@mirantis.com>2016-05-12 18:23:18 +0300
commit425d919b8acfc05a4af20799936fab5772cd698c (patch)
tree27e44dfc24fa6f1ce74bab103a514293e8125ba0
parent5c164b6bea214ea3e776327e86aeff7d6b8a1935 (diff)
Enable no-this-before-super
In the constructor of derived classes, if this/super are used before super() calls, it raises a reference error. http://eslint.org/docs/rules/no-this-before-super Change-Id: I7cd9f2e802dbc1b3e9e91ca708366cb2b461e7fb
Notes
Notes (review): Code-Review+1: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Julia Aranovich <jkirnosova@mirantis.com> Code-Review+1: Kate Pimenova <kpimenova@mirantis.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 02 Jun 2016 16:08:35 +0000 Reviewed-on: https://review.openstack.org/315633 Project: openstack/eslint-config-openstack Branch: refs/heads/master
-rw-r--r--.eslintrc2
1 files changed, 1 insertions, 1 deletions
diff --git a/.eslintrc b/.eslintrc
index 2c821ce..09f4915 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -895,7 +895,7 @@ rules:
895 895
896 # disallow use of this/super before calling super() in constructors 896 # disallow use of this/super before calling super() in constructors
897 # http://eslint.org/docs/rules/no-this-before-super 897 # http://eslint.org/docs/rules/no-this-before-super
898 no-this-before-super: 0 898 no-this-before-super: 2
899 899
900 # disallow unnecessary constructor 900 # disallow unnecessary constructor
901 # http://eslint.org/docs/rules/no-useless-constructor 901 # http://eslint.org/docs/rules/no-useless-constructor