summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElizabeth Elwell <e.r.elwell@gmail.com>2016-08-03 12:39:34 +0100
committerElizabeth Elwell <e.r.elwell@gmail.com>2016-08-05 14:55:18 +0100
commit4f5cae9232bce9c335769e1b327658b05ce173e1 (patch)
treead20beb4e09e13566b2a79a5b2ec8314e56abeba
parentec845e5e7fe3a9fb7b106c791cded2a283ebe42d (diff)
Upgraded eslint to 3.0.0
This upgrades the eslint version to 3.0.0, removes zombie rules, and ensures all new rules are disabled. Change-Id: I8ea98aeda7a42ed0e140164c0e9d5e28d54794b8
Notes
Notes (review): Code-Review+1: Mitchell Smolash <mitch@smolash.com> Code-Review+2: Michael Krotscheck <krotscheck@gmail.com> Code-Review+1: Zara <zara.zaimeche@codethink.co.uk> Workflow+1: Beth Elwell <e.r.elwell@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Fri, 05 Aug 2016 15:52:31 +0000 Reviewed-on: https://review.openstack.org/350530 Project: openstack/eslint-config-openstack Branch: refs/heads/master
-rw-r--r--.eslintrc65
-rw-r--r--package.json4
2 files changed, 60 insertions, 9 deletions
diff --git a/.eslintrc b/.eslintrc
index b0fde17..d708219 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -59,12 +59,6 @@ rules:
59 # Possible Errors 59 # Possible Errors
60 ############################################################################# 60 #############################################################################
61 61
62 # Disallow trailing commas, as those break some browsers.
63 # http://eslint.org/docs/rules/comma-dangle
64 comma-dangle:
65 - 2
66 - "never"
67
68 # Prevent the assignment of a variable in a conditional. 62 # Prevent the assignment of a variable in a conditional.
69 # http://eslint.org/docs/rules/no-cond-assign 63 # http://eslint.org/docs/rules/no-cond-assign
70 no-cond-assign: 2 64 no-cond-assign: 2
@@ -97,6 +91,11 @@ rules:
97 # http://eslint.org/docs/rules/no-duplicate-case 91 # http://eslint.org/docs/rules/no-duplicate-case
98 no-duplicate-case: 2 92 no-duplicate-case: 2
99 93
94 # Do not require that all imports from a single module exist in a single
95 # import statement.
96 #http://eslint.org/docs/rules/no-duplicate-imports
97 no-duplicate-imports: 0
98
100 # Disallow empty regex character classes. (/[]/) 99 # Disallow empty regex character classes. (/[]/)
101 # http://eslint.org/docs/rules/no-empty-character-class 100 # http://eslint.org/docs/rules/no-empty-character-class
102 no-empty-character-class: 2 101 no-empty-character-class: 2
@@ -139,6 +138,10 @@ rules:
139 # http://eslint.org/docs/rules/no-irregular-whitespace 138 # http://eslint.org/docs/rules/no-irregular-whitespace
140 no-irregular-whitespace: 2 139 no-irregular-whitespace: 2
141 140
141 # Allow mixes of different operators without parantheses
142 # http://eslint.org/docs/rules/no-mixed-operators
143 no-mixed-operators: 0
144
142 # Disallow negation of the left operand of an in expression 145 # Disallow negation of the left operand of an in expression
143 # http://eslint.org/docs/rules/no-negated-in-lhs 146 # http://eslint.org/docs/rules/no-negated-in-lhs
144 no-negated-in-lhs: 2 147 no-negated-in-lhs: 2
@@ -147,6 +150,10 @@ rules:
147 # http://eslint.org/docs/rules/no-obj-calls 150 # http://eslint.org/docs/rules/no-obj-calls
148 no-obj-calls: 2 151 no-obj-calls: 2
149 152
153 # Allow use of Object.prototypes builtins directly
154 # http://eslint.org/docs/rules/no-prototype-builtins
155 no-prototype-builtins: 0
156
150 # Disallow multiple spaces in a regular expression literal 157 # Disallow multiple spaces in a regular expression literal
151 # http://eslint.org/docs/rules/no-regex-spaces 158 # http://eslint.org/docs/rules/no-regex-spaces
152 no-regex-spaces: 2 159 no-regex-spaces: 2
@@ -159,6 +166,22 @@ rules:
159 # http://eslint.org/docs/rules/no-unreachable 166 # http://eslint.org/docs/rules/no-unreachable
160 no-unreachable: 2 167 no-unreachable: 2
161 168
169 # Re-allow return, throw, break, and continue statements inside finally blocks.
170 # http://eslint.org/docs/rules/no-unsafe-finally
171 no-unsafe-finally: 0
172
173 # Allow unnecessary computed property keys on objects
174 # http://eslint.org/docs/rules/no-useless-computed-key
175 no-useless-computed-key: 0
176
177 # Allow unnecessary escape usage
178 # http://eslint.org/docs/rules/no-useless-escape
179 no-useless-escape: 0
180
181 # Allow renaming import, export, and destructured assignments to the same name
182 # http://eslint.org/docs/rules/no-useless-rename
183 no-useless-rename: 0
184
162 # Disallow comparisons with the value NaN 185 # Disallow comparisons with the value NaN
163 # http://eslint.org/docs/rules/use-isnan 186 # http://eslint.org/docs/rules/use-isnan
164 use-isnan: 2 187 use-isnan: 2
@@ -581,6 +604,10 @@ rules:
581 - 2 604 - 2
582 - properties: "never" 605 - properties: "never"
583 606
607 # Do not require or disallow trailing commas
608 # http://eslint.org/docs/rules/comma-dangle
609 comma-dangle: 0
610
584 # Enforce spacing before and after comma 611 # Enforce spacing before and after comma
585 # http://eslint.org/docs/rules/comma-spacing 612 # http://eslint.org/docs/rules/comma-spacing
586 comma-spacing: 0 613 comma-spacing: 0
@@ -652,12 +679,20 @@ rules:
652 - 2 679 - 2
653 - "unix" 680 - "unix"
654 681
682 # Do not enforce a maximum file length
683 # http://eslint.org/docs/rules/max-lines
684 max-lines: 0
685
655 # Specify the maximum depth callbacks can be nested 686 # Specify the maximum depth callbacks can be nested
656 # http://eslint.org/docs/rules/max-nested-callbacks 687 # http://eslint.org/docs/rules/max-nested-callbacks
657 max-nested-callbacks: 688 max-nested-callbacks:
658 - 0 689 - 0
659 - 3 690 - 3
660 691
692 # Do not enforce a maximum number of statements allowed per line
693 #http://eslint.org/docs/rules/max-statements-per-line
694 max-statements-per-line: 0
695
661 # Require a capital letter for constructors 696 # Require a capital letter for constructors
662 # http://eslint.org/docs/rules/new-cap 697 # http://eslint.org/docs/rules/new-cap
663 new-cap: 0 698 new-cap: 0
@@ -704,7 +739,7 @@ rules:
704 - 2 739 - 2
705 - max: 1 740 - max: 1
706 741
707 # disallow negated conditions 742 # Disallow negated conditions
708 # http://eslint.org/docs/rules/no-negated-condition 743 # http://eslint.org/docs/rules/no-negated-condition
709 no-negated-condition: 0 744 no-negated-condition: 0
710 745
@@ -744,10 +779,18 @@ rules:
744 # http://eslint.org/docs/rules/no-whitespace-before-property 779 # http://eslint.org/docs/rules/no-whitespace-before-property
745 no-whitespace-before-property: 0 780 no-whitespace-before-property: 0
746 781
782 # Do not enforce consistent line breaks inside braces
783 # http://eslint.org/docs/rules/object-curly-newline
784 object-curly-newline: 0
785
747 # Require or disallow padding inside curly braces 786 # Require or disallow padding inside curly braces
748 # http://eslint.org/docs/rules/object-curly-spacing 787 # http://eslint.org/docs/rules/object-curly-spacing
749 object-curly-spacing: 0 788 object-curly-spacing: 0
750 789
790 # Do not enforce placing object properties on separate lines
791 # http://eslint.org/docs/rules/object-property-newline
792 object-property-newline: 0
793
751 # Allow or disallow one variable declaration per function 794 # Allow or disallow one variable declaration per function
752 # http://eslint.org/docs/rules/one-var 795 # http://eslint.org/docs/rules/one-var
753 one-var: 796 one-var:
@@ -787,6 +830,10 @@ rules:
787 # http://eslint.org/docs/rules/require-jsdoc 830 # http://eslint.org/docs/rules/require-jsdoc
788 require-jsdoc: 0 831 require-jsdoc: 0
789 832
833 # Do not enforce spacing between rest and spread operators and their expressions
834 # http://eslint.org/docs/rules/rest-spread-spacing
835 rest-spread-spacing: 0
836
790 # Enforce spacing before and after semicolons 837 # Enforce spacing before and after semicolons
791 # http://eslint.org/docs/rules/semi-spacing 838 # http://eslint.org/docs/rules/semi-spacing
792 semi-spacing: 839 semi-spacing:
@@ -841,6 +888,10 @@ rules:
841 # http://eslint.org/docs/rules/spaced-comment 888 # http://eslint.org/docs/rules/spaced-comment
842 spaced-comment: 0 889 spaced-comment: 0
843 890
891 # Do not require or disallow the Unicode Byte Order Mark (BOM)
892 # http://eslint.org/docs/rules/unicode-bom
893 unicode-bom: 0
894
844 # require regex literals to be wrapped in parentheses 895 # require regex literals to be wrapped in parentheses
845 # http://eslint.org/docs/rules/wrap-regex 896 # http://eslint.org/docs/rules/wrap-regex
846 wrap-regex: 0 897 wrap-regex: 0
diff --git a/package.json b/package.json
index 8fe39c1..5f35222 100644
--- a/package.json
+++ b/package.json
@@ -32,10 +32,10 @@
32 }, 32 },
33 "homepage": "https://wiki.openstack.org/wiki/QA", 33 "homepage": "https://wiki.openstack.org/wiki/QA",
34 "peerDependencies": { 34 "peerDependencies": {
35 "eslint": "^2.4.0" 35 "eslint": "^3.0.0"
36 }, 36 },
37 "devDependencies": { 37 "devDependencies": {
38 "eslint": "2.4.0", 38 "eslint": "3.0.0",
39 "jasmine": "2.3.1" 39 "jasmine": "2.3.1"
40 }, 40 },
41 "dependencies": { 41 "dependencies": {