summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Krotscheck <krotscheck@gmail.com>2016-03-16 08:13:03 -0700
committerMichael Krotscheck <krotscheck@gmail.com>2016-05-04 12:40:36 -0700
commit8442d0103b36090de4b4c563cfef2a45c94cbf88 (patch)
tree44a3291360963cdaadb48cf3760113dc9d6b7813
parentc2dfae499947999ad6a1d835e742ad74c5d5176d (diff)
Enable no-unmodified-loop-condition
This rule ensures that parameters used to declare a loop, are modified within the loop. If they are not, it is likely that this is an error. Example: while(foo) { doSomething(foo); } http://eslint.org/docs/rules/no-unmodified-loop-condition Change-Id: I8f5a0b2b1f48a9f93e0946c76c497e86a199f01e
Notes
Notes (review): Code-Review+1: Frank White <francoblanco.openstack@gmail.com> Code-Review+2: Beth Elwell <e.r.elwell@gmail.com> Code-Review+2: Timur Sufiev <tsufiev@mirantis.com> Code-Review+1: Vitaly Kramskikh <vkramskikh@mirantis.com> Code-Review+1: Dong Ma <winterma.dong@gmail.com> Code-Review+1: Zara <zara.zaimeche@codethink.co.uk> Workflow+1: Michael Krotscheck <krotscheck@gmail.com> Verified+2: Jenkins Submitted-by: Jenkins Submitted-at: Thu, 21 Jul 2016 16:21:30 +0000 Reviewed-on: https://review.openstack.org/293499 Project: openstack/eslint-config-openstack Branch: refs/heads/master
-rw-r--r--.eslintrc2
1 files changed, 1 insertions, 1 deletions
diff --git a/.eslintrc b/.eslintrc
index 883ab2a..bd3c0db 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -397,7 +397,7 @@ rules:
397 397
398 # disallow unmodified conditions of loops 398 # disallow unmodified conditions of loops
399 # http://eslint.org/docs/rules/no-unmodified-loop-condition 399 # http://eslint.org/docs/rules/no-unmodified-loop-condition
400 no-unmodified-loop-condition: 0 400 no-unmodified-loop-condition: 2
401 401
402 # Disallow usage of expressions in statement position 402 # Disallow usage of expressions in statement position
403 # http://eslint.org/docs/rules/no-unused-expressions 403 # http://eslint.org/docs/rules/no-unused-expressions